[1.x] Use dedicated config value for trimming storage #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
changed the title
timacdonald
force-pushed
the
storage-trim
branch
from
9a66446 to
cdf3040
Compare
timacdonald
force-pushed
the
storage-trim
branch
from
cdf3040 to
1fe5a97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to #424.
It introduces a dedicated trim config for the storage driver.
The recommended set up for Pulse installed on any high traffic application is using the Redis ingest and the Database storage. Having a dedicated config for storage allows you to have, say, 3 days of data in storage while maintaining only a couple of hours in the ingest.
Redis is likely to fall over if you tried to keep 3 days worth of data in it. The ingest trim is there as a safety mechanism in case the
pulse:workcommand goes down.So these two config values often serve a different purpose.
This PR also ensures that the configured storage trim duration is not greater than 7 days, which is the longest period Pulse supports.