Skip to content

Conversation

@nforst
Copy link

@nforst nforst commented Oct 28, 2025

I have added that a separate dnsmasq config is created for each site or proxy. The exact explanation is in this feature request

#1534

@drbyte
Copy link
Contributor

drbyte commented Oct 30, 2025

You are correct that you can add multiple .conf files into the dnsmasq.d directory for dnsmasq to pick up and let you customize.

The problem I see with this PR in its current state (unless I'm misreading the code) is that by making it per-host-only you've removed the generic *.test (or whatever configured tld) resolver that allows you to use http://foo.test by simply creating a foo directory in your Sites directory (all the other parked paths you've added in the valet config file).

@nforst
Copy link
Author

nforst commented Oct 30, 2025

You are correct that you can add multiple .conf files into the dnsmasq.d directory for dnsmasq to pick up and let you customize.

The problem I see with this PR in its current state (unless I'm misreading the code) is that by making it per-host-only you've removed the generic *.test (or whatever configured tld) resolver that allows you to use http://foo.test by simply creating a foo directory in your Sites directory (all the other parked paths you've added in the valet config file).

I completely forgot about that. I'll see if I can find a solution and then commit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants