chore(quality): add quality tools #316
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like this PR is making a massive amount of trivial changes. I am all for more linters, but I am not going to accept massive changes where all that changes is the type of python quoting used or similar changes, the code base is to big and mature for that kind of change, it would clobber history (git blame) for no good reason. |
Author
|
Agreed, I'll proceed to changes and ping you once this PR is ready to be reviewed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to add quality tools (flake8, black, pyupgrade, mypy), locally using pre-commit and in the CI.
Technical details
flake8and run the tool on the codebaseblackand run the tool on the codebasepyupgradeand run the tool on the codebasemypyand run the tool on the codebaseTODO
mypyintegrationisortcheck-yamlFuture work
mypyrunning on the codebase, addpy.typedmarker so that library usage of external projects can also be type-checked.