Initial issues dashboard with filters #1860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
force-pushed
the
feature/issues-plumbing
branch
9 times, most recently
from
c08e609 to
d4630fa
Compare
andresgutgon
commented
Oct 30, 2025
There was a problem hiding this comment.
This monster query deserves tests. However, I won't be doing that in this PR, so I want to move on to another thing. Anyway this is not yet released
andresgutgon
force-pushed
the
feature/issues-plumbing
branch
from
d4630fa to
70b99c2
Compare
andresgutgon
force-pushed
the
feature/issues-plumbing
branch
from
70b99c2 to
b946a8a
Compare
andresgutgon
changed the title
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
| /** | ||
| * SWR cache key for issues list based on filters and sorting | ||
| */ | ||
| export function buildIssuesCacheKey({ |
There was a problem hiding this comment.
This is more simpler if you just add the query string to the SWR cache key.... look how eval results v2 store work
There was a problem hiding this comment.
I'll keep this way for now
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
...private)/projects/[projectId]/versions/[commitUuid]/issues/_components/IssuesTitle/index.tsx
Outdated
Show resolved
Hide resolved
neoxelox
reviewed
Oct 30, 2025
...private)/projects/[projectId]/versions/[commitUuid]/issues/_components/IssuesTitle/index.tsx
Outdated
Show resolved
Hide resolved
neoxelox
reviewed
Oct 30, 2025
...private)/projects/[projectId]/versions/[commitUuid]/issues/_components/IssuesTable/index.tsx
Outdated
Show resolved
Hide resolved
neoxelox
reviewed
Oct 30, 2025
| const status = filters.status ?? serverParams.filters.status | ||
| const showStatus = status !== 'active' | ||
|
|
||
| if (noData) return <TableBlankSlate description='No issues in this project' /> |
There was a problem hiding this comment.
Suggested change
| if (noData) return <TableBlankSlate description='No issues in this project' /> | |
| if (noData) return <TableBlankSlate description='No issues found for this prompt yet' /> |
There was a problem hiding this comment.
It could be for all prompts if no document is selected
neoxelox
reviewed
Oct 30, 2025
| }: { | ||
| workspace: Workspace | ||
| project: Project | ||
| documentUuid: string |
There was a problem hiding this comment.
why not pass the document here?
There was a problem hiding this comment.
I'll change when I use it in the next PR
neoxelox
reviewed
Oct 30, 2025
| }, | ||
| transaction = new Transaction(), | ||
| ) { | ||
| return transaction.call(async (tx) => { |
There was a problem hiding this comment.
we should publish an issueCreated event maybe?
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
reviewed
Oct 30, 2025
neoxelox
previously requested changes
Oct 30, 2025
andresgutgon
force-pushed
the
feature/issues-plumbing
branch
3 times, most recently
from
db9bda0 to
d3f9698
Compare
andresgutgon
force-pushed
the
feature/issues-plumbing
branch
from
d3f9698 to
a031b03
Compare
andresgutgon
dismissed
neoxelox’s stale review
Moved date filters to subquery in a having clause as requested
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implement base files for issue models
TODO
Make back navigation work from the middle.Implemented page/offset finallydirection=backwardescalatingwarning andnewaccent no iconsSeen at11d ago / 3yr oldnormaldefault andsmallwithout fancy layer and 32px max like a normal button.Last seen up to ...