Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Essentially, resolves black horizontal banding artifact in specific MacOS profiles with Chrome.
Users on specific hardware profiles (specifically macOS with discrete/integrated GPU switching, like the i9 MacBook Pro) were experiencing a rendering artifact in Chrome. A solid black horizontal band would appear across the middle of the screen, occupying the empty space between the
<main>content and the<footer>.This issue did not occur in Firefox or Safari.
Root Cause
This is caused by a hardware acceleration and compositing glitch in Chrome's rendering engine (Blink).
min-h-screenflex container with aflex-1main content area to push the footer to the bottom.flex-1contains no DOM nodes.<body>background shine through.Instead, it leaves an uninitialized GPU tile, which renders in Skia/ANGLE as pure black.
The Fix
Applied a "double paint" technique. By moving/adding the explicit background color classes (
bg-gray-50 dark:bg-slate-950) directly to the root flex wrapper inApp.tsx, we stop relying on the<div id="root">'s background to show through a transparent container. This forces Chrome's compositor to explicitly paint the color data into those stretched flex tiles, overriding the buggy optimization step.