Enterprise addons stickey dropdown #6963
Open
+251
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChetanFTW
force-pushed
the
enterprise_addons-stickey_dropdown
branch
from
e3286d0 to
bc63541
Compare
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
ChetanFTW
force-pushed
the
enterprise_addons-stickey_dropdown
branch
from
bc63541 to
1a35f40
Compare
Signed-off-by: Saurabh Singh <saurabhsraghuvanshi@gmail.com>
Signed-off-by: ChetanFTW <devchetan42@gmail.com>
|
🚀 Preview for commit a1ba371 at: https://68dd720664d4fb123e2779cc--layer5.netlify.app |
|
@ChetanFTW please tag the pr with respective issue |
sudhanshutech
suggested changes
Oct 2, 2025
| }, []); | ||
|
|
||
| useEffect(() => { | ||
| if (!addonMenuOpen) return; |
There was a problem hiding this comment.
again why such low level logic and manipulating the dom for such purposes? We use mui/sistent design system for such purposes only. This should handled by component itself
There was a problem hiding this comment.
same for here
I tried using the standard MUI components first, but a CSS conflict elsewhere in the app was preventing them from working correctly.
This manual useEffect is a necessary override
|
I mentioned issue in description |
Signed-off-by: Chetan 👾 <128224987+ChetanFTW@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #6950
Signed commits
Screencast.from.2025-09-15.12-11-35.webm