Messy version of allowing resources to link to imported resources#1213
Draft
Messy version of allowing resources to link to imported resources#1213
Conversation
3962b07 to
cf21e31
Compare
57973ea to
b7b9a77
Compare
7 tasks
b7b9a77 to
0952376
Compare
50fdd2f to
513bc0c
Compare
Contributor
|
@piemonkey do you think this PR is still necessary? I don't think this is really a usecase right? |
Contributor
Author
|
This definitely isn't something we need right now, but I think it's something that makes sense as there's no reason why relationships should need to have the subject in the outer document rather than the subject being inside the snippet. |
09a205a to
e9b510d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
To allow for linking from resources in a snippet to those imported, adds imported resources to those listed for creating relationships, but actually the linking only works if we create a NamedNode relationship instead of a ResourceNode. This is just a draft as we need to figure out a better way to do this.
connected issues and PRs:
Made to #1212 as that is the more finalised part of the design.
Setup
Link to plugins PR.
How to test/reproduce
See plugins PR for most details. When creating a link to an imported resource from a resource in the snippet, click 'add relationship' as normal, but create a NamedNode link with a manually entered URI.
Challenges/uncertainties
Need to figure out the right way to do this.
Checks PR readiness