Skip to content

Conversation

@tip2tail
Copy link

Fixes #61.

I created this PR to add Symfony 5.4 compatibility. There was a change to the Symfony\Bundle\SecurityBundle\DependencyInjection\Security\Factory\FormLoginFactory class in Symfony 5.4 that means we must provide the return types as part of the method signatures in LdapFormLoginFactory.

@tip2tail
Copy link
Author

Paging @ChadSikorra - is this something you can check ad release please? Without this change, the bundle cannot be used in Symfony 5.4.

Young, Mark added 2 commits November 30, 2021 21:10
…b.com:tip2tail/ldaptools-bundle into issue-61-compatibility-with-symfony-5-point-4
@tip2tail
Copy link
Author

CC: @SebDev94 - might want to update your branch as well :)

@ramieita
Copy link

@tip2tail any Update ?

@tip2tail
Copy link
Author

@ramieita Not sure what you are asking me on this one? I have not heard anything about this being merged yet.

You could use my branch instead which is what I am doing in my project

@ramieita
Copy link

@tip2tail i meant if this issue has been fixed or not , but obviously not :)

@HelloSebastian
Copy link

@tip2tail I have taken the fork from SebDev94. Thanks for the information! As soon as I use ldaptools in Symfony 5.4 I will update my branch.

Did you also have problems with the Doctrine cache? When I upgraded to Symfony 5.3, I had to downgrade the doctrine/cache to 1.12.1. Doctrine apparently deleted the cache in higher versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compatibility with Symfony 5.4

4 participants