-
Notifications
You must be signed in to change notification settings - Fork 29
Fixes #61. Add return type to methods #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixes #61. Add return type to methods #62
Conversation
|
Paging @ChadSikorra - is this something you can check ad release please? Without this change, the bundle cannot be used in Symfony 5.4. |
…b.com:tip2tail/ldaptools-bundle into issue-61-compatibility-with-symfony-5-point-4
|
CC: @SebDev94 - might want to update your branch as well :) |
|
@tip2tail any Update ? |
|
@ramieita Not sure what you are asking me on this one? I have not heard anything about this being merged yet. You could use my branch instead which is what I am doing in my project |
|
@tip2tail i meant if this issue has been fixed or not , but obviously not :) |
|
@tip2tail I have taken the fork from SebDev94. Thanks for the information! As soon as I use ldaptools in Symfony 5.4 I will update my branch. Did you also have problems with the Doctrine cache? When I upgraded to Symfony 5.3, I had to downgrade the |
Fixes #61.
I created this PR to add Symfony 5.4 compatibility. There was a change to the
Symfony\Bundle\SecurityBundle\DependencyInjection\Security\Factory\FormLoginFactoryclass in Symfony 5.4 that means we must provide the return types as part of the method signatures inLdapFormLoginFactory.