fix(fastify-rdf): return 400 for malformed JSON-LD body#194
Merged
Conversation
- Set statusCode = 400 on SyntaxError before passing to Fastify's done() callback; without it Fastify defaults to 500 - Add test for malformed JSON-LD returning 400
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a request with
Content-Type: application/ld+jsoncontains malformed JSON, the content type parser'sJSON.parsethrows aSyntaxError. This error was passed to Fastify viadone(err)without settingstatusCode, so Fastify defaulted to 500.statusCode = 400on theSyntaxErrorbefore passing it to Fastify'sdone()callbackFix #191