Initial IdealFluid structure#949
Draft
mog1el wants to merge 2 commits intolean-phys-community:masterfrom
Draft
Conversation
PhysLean/FluidMechanics/Basic.lean
Outdated
| structure IdealFluid where | ||
| density: Time → Space → ℝ | ||
| velocity: Time → Space→ Space | ||
| pressure: Time → Space → ℝ |
Member
There was a problem hiding this comment.
You might want to think about the conditions that you put here. Do e.g. L&L suggest that the density need by a smooth function? Does it need to have certain properties with respect to integration? etc.
PhysLean/FluidMechanics/Basic.lean
Outdated
|
|
||
| structure IdealFluid where | ||
| density: Time → Space → ℝ | ||
| velocity: Time → Space→ Space |
Member
There was a problem hiding this comment.
I would make velocity a map to EluclideanSpace _ _ rather than Space.
PhysLean/FluidMechanics/Basic.lean
Outdated
| Copyright (c) 2026 Michał Mogielnicki. All rights reserved. | ||
| Released under Apache 2.0 license as described in the file LICENSE. | ||
| Authors: Michał Mogielnicki | ||
| -/ |
Member
There was a problem hiding this comment.
Would move this .Basic.lean file into the directory IdealFluid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing issue #887