Conversation
|
@jstoobysmith line 358 of https://github.com/lean-phys-community/PhysLean/blob/master/PhysLean/SpaceAndTime/Time/TimeTransMan.lean broke, the edit: managed to prove by |
|
Here is a mwe: import Mathlib
example (f : ℝ → ℝ) (hf : Differentiable ℝ f) : Continuous f := by fun_prop -- works in v4.27.0 but not in v4.28.0 |
|
I think I managed to get both, PseudoRiemannianMetric is symmetric therefore one side is enough, the proof can probably be golfed though. The Time.val issue is due to a change in #34345. Moved zulip discussion to new thread at https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60fun_prop.60.20doesn't.20apply.20Differentiable.2Econtinuous/with/575029767 |
jstoobysmith
left a comment
There was a problem hiding this comment.
Approved - many thanks for being on top of this. Hopefully this was somewhat less painful then v4.27.0
|
#954 - link to issue for reference. |
@or4nge19 In v4.28.0 the definition of
BilinForm.Nondegeneratechanged to anabbrevofLinearMap.Nondegenerate. (see https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Nondegenerate.20bilinear.20.2F.20quadratic.20forms/with/568863325 and leanprover-community/mathlib4#34110). In particular, this proof in https://github.com/lean-phys-community/PhysLean/blob/master/PhysLean/Mathematics/Geometry/Metric/PseudoRiemannian/Defs.lean broke:but I thought you might want to check if the whole definition needs updating.