refactor: replace dependency gitpkg.vercel.app dependencies#431
refactor: replace dependency gitpkg.vercel.app dependencies#431joneugster merged 3 commits intomainfrom
Conversation
|
Not sure what the status of this PR is, but I was able (with Codex) to get a fork of the remove-vercel branch working on a few games and passing all of the Cypress tests here: https://github.com/RichardKelley/lean4game/tree/remove-vercel I don't want to propose a competing PR if this one is moving forward; if the above is useful I'm happy to help integrate or do additional testing. |
|
Thats great. I didnt have the time to finish this. |
|
Your branch looks okay, although I don't fully understand all the changes, but that's okay, I think. Can you open a PR and maybe comment on why the duplicated definitions in |
|
Let me see if I can get rid of |
relay/src/serverProcess.ts
Outdated
| // Find an ancestor that contains the lean4game directory. | ||
| let current = this.dir | ||
| for (let i = 0; i < 10; i++) { | ||
| if (fs.existsSync(path.join(current, 'lean4game'))) { |
There was a problem hiding this comment.
This isn't really stable. User might have multiple instances of the repo on the computer and the clone might have a different name
Max recursion when a game does not exist or isn't built. |
Might be unrelated to this PR. |
joneugster
force-pushed
the
remove-vercel
branch
from
3d0727a to
bbb5f31
Compare
|
Thank you @abentkamp and @RichardKelley ! I verified it working locally |
Co-authored-by: Richard Kelley <richard.kelley@gmail.com> Co-authored-by: Jon Eugster <eugster.jon@gmail.com>
|
Could you port this to older branches like bump-v4.23.0? RealAnalysisGame is not compiling now. My workaround is also not working. |
|
I think the simplest solution is to bump RealAnalysisGame... I'll try to see if I can assist the author |
I've tried to do so. |
4 participants
Fixes #416