chore(100.html): fix dead links to non-Mathlib declarations#785
Open
Vierkantor wants to merge 1 commit intolean4from
Open
chore(100.html): fix dead links to non-Mathlib declarations#785Vierkantor wants to merge 1 commit intolean4from
Vierkantor wants to merge 1 commit intolean4from
Conversation
This PR fixes that non-Mathlib declarations in the top 100 and top 1000 theorems link to the correct docs page. In the code listings for the top 100 and 1000 theorems, doc-gen generates links to the definitions of bits of code. But they are relative to /mathlib4_docs. We tried to fix this by rewriting relative links like `href="./Mathlib` to `href="./mathlib4_docs/Mathlib`, but we should do the same for Init and Batteries and ... So this PR instead rewrites all links from `href="./` to `href="./mathlib4_docs`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes that non-Mathlib declarations in the top 100 and top 1000 theorems didn't have the right URL. In the code listings for the top 100 and 1000 theorems, doc-gen generates links to the definitions of bits of code. But they are relative to /mathlib4_docs. We tried to fix this by rewriting relative links like
href="./Mathlibtohref="./mathlib4_docs/Mathlib, but we should do the same for Init and Batteries and ... So this PR instead rewrites all links fromhref="./tohref="./mathlib4_docs.