You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
+ Subgroup.continuousConstSMul + instNormedGroup + instSeminormedGroup + instance (priority := 100) NormedGroup.to_isIsometricSMul_left : IsIsometricSMul E E + instance (priority := 100) SeminormedGroup.toIsTopologicalGroup : IsTopologicalGroup E + instance (priority := 100) SeminormedGroup.to_isUniformGroup : IsUniformGroup E + instance (priority := 100) SeminormedGroup.to_lipschitzMul : LipschitzMul E + isPretransitive_mulOpposite_quotient - NormedGroup.to_isIsometricSMul_left
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
YaelDillies
changed the title
refactor(Normed/Group/Quotient): generalise to non-commutative groups
refactor(Normed/Group/Quotient): generalise to non-abelian groups
Feb 2, 2025
github-actionsbot
removed
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
large-import
Automatically added label for PRs with a significant increase in transitive imports
labels
Mar 17, 2025
I don't understand the comment in the PR description. In the free group with the word distance wrt the standard set of generators, left-multiplication is indeed an isometry, but right-multiplication is not. For instance, d (a, b) = 2 and d (ab, b^2) = 4.
In fact, looking at our definition of SeminormedGroup, the distance is given by dist x y = ‖x / y‖. This looks bad: for this distance, left-multiplication is not an isometry, and x is not close to xs if s is small. Am I missing something?
Yes, I agree. Will you refactor SeminormedGroup to make right multiplication an isometry? I believe this is what's needed to make the current PR non-stupid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocked-by-other-PRThis PR depends on another PR (this label is automatically managed by a bot)t-analysisAnalysis (normed *, calculus)
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to apply this to free groups, whose multiplication in either argument is an isometry, but isn't commutative.