Skip to content

[Merged by Bors] - feat(CategoryTheory/Category/Preorder): isIso_homOfLE#33877

Closed
joelriou wants to merge 4 commits intoleanprover-community:masterfrom
joelriou:spectral-3-category-preorder
Closed

[Merged by Bors] - feat(CategoryTheory/Category/Preorder): isIso_homOfLE#33877
joelriou wants to merge 4 commits intoleanprover-community:masterfrom
joelriou:spectral-3-category-preorder

Conversation

@joelriou
Copy link
Contributor

@joelriou joelriou commented Jan 12, 2026

We add the lemma isIso_homOfLE which shows that homOfLE is an isomorphism when x = y.


Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Jan 12, 2026
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

PR summary 2b4c6152f1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ isIso_homOfLE

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

IsIso (homOfLE h) :=
⟨homOfLE (le_of_eq heq.symm), by simp⟩

lemma isIso_homOfLE {x y : X} (h : x = y) :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be weakened to AntisymmRel (· ≤ ·) x y, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require an extra import. Anyway, the more useful basic lemma would still be the one using an equality as an assumption.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If AntisymmRel is a heavy import by any measure, then we should refactor the file!

Copy link
Contributor

@robin-carlier robin-carlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think not much is gained by generalizing to AntisymmRel, and that the most important case that will show up in practice in almost all cases is the one with equality,
so

Thanks!

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 16, 2026
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jan 16, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2026
We add the lemma `isIso_homOfLE` which shows that `homOfLE` is an isomorphism when `x = y`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2026

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2026
We add the lemma `isIso_homOfLE` which shows that `homOfLE` is an isomorphism when `x = y`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2026

Canceled.

@joelriou
Copy link
Contributor Author

Retrying....

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2026
We add the lemma `isIso_homOfLE` which shows that `homOfLE` is an isomorphism when `x = y`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/Category/Preorder): isIso_homOfLE [Merged by Bors] - feat(CategoryTheory/Category/Preorder): isIso_homOfLE Jan 16, 2026
@mathlib-bors mathlib-bors bot closed this Jan 16, 2026
eliasjudin pushed a commit to eliasjudin/mathlib4 that referenced this pull request Jan 18, 2026
…munity#33877)

We add the lemma `isIso_homOfLE` which shows that `homOfLE` is an isomorphism when `x = y`.
bilichboris pushed a commit to bilichboris/mathlib4 that referenced this pull request Jan 18, 2026
…munity#33877)

We add the lemma `isIso_homOfLE` which shows that `homOfLE` is an isomorphism when `x = y`.
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
…munity#33877)

We add the lemma `isIso_homOfLE` which shows that `homOfLE` is an isomorphism when `x = y`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants