[Merged by Bors] - feat(CategoryTheory/Category/Preorder): isIso_homOfLE#33877
[Merged by Bors] - feat(CategoryTheory/Category/Preorder): isIso_homOfLE#33877joelriou wants to merge 4 commits intoleanprover-community:masterfrom
Conversation
PR summary 2b4c6152f1Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
| IsIso (homOfLE h) := | ||
| ⟨homOfLE (le_of_eq heq.symm), by simp⟩ | ||
|
|
||
| lemma isIso_homOfLE {x y : X} (h : x = y) : |
There was a problem hiding this comment.
This can be weakened to AntisymmRel (· ≤ ·) x y, right?
There was a problem hiding this comment.
This would require an extra import. Anyway, the more useful basic lemma would still be the one using an equality as an assumption.
There was a problem hiding this comment.
If AntisymmRel is a heavy import by any measure, then we should refactor the file!
robin-carlier
left a comment
There was a problem hiding this comment.
I also think not much is gained by generalizing to AntisymmRel, and that the most important case that will show up in practice in almost all cases is the one with equality,
so
Thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by robin-carlier. |
We add the lemma `isIso_homOfLE` which shows that `homOfLE` is an isomorphism when `x = y`.
|
Build failed (retrying...): |
We add the lemma `isIso_homOfLE` which shows that `homOfLE` is an isomorphism when `x = y`.
|
Canceled. |
|
Retrying.... bors merge |
We add the lemma `isIso_homOfLE` which shows that `homOfLE` is an isomorphism when `x = y`.
|
Pull request successfully merged into master. Build succeeded: |
…munity#33877) We add the lemma `isIso_homOfLE` which shows that `homOfLE` is an isomorphism when `x = y`.
…munity#33877) We add the lemma `isIso_homOfLE` which shows that `homOfLE` is an isomorphism when `x = y`.
…munity#33877) We add the lemma `isIso_homOfLE` which shows that `homOfLE` is an isomorphism when `x = y`.
We add the lemma
isIso_homOfLEwhich shows thathomOfLEis an isomorphism whenx = y.