[Merged by Bors] - chore: link to mathlib4 docs page in library overview#35129
[Merged by Bors] - chore: link to mathlib4 docs page in library overview#35129Vierkantor wants to merge 3 commits intomasterfrom
Conversation
This PR fixes a few dead links on the library overview page: we link to docgen pages for modules, rather than a specific declaration there. But those links still used the mathlib3 naming conventions; update to mathlib4.
PR summary 0528bce2a0Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
There was a problem hiding this comment.
Thank you for your contribution!
Currently, on the overview page, "limit infimum and supremum" links to https://leanprover-community.github.io/mathlib4_docs/order/liminf_limsup.html, which returns 404 error.
So this change is reasonable.
Indeed, the linking is done in the following two piexes of code:
According to this code, your change will probably work fine.
However, could you also update the following links in undergrad.yaml?
Line 175 in 05a9b62
Line 188 in 05a9b62
Line 286 in 05a9b62
Line 363 in 05a9b62
|
Thanks to @Komyyy for linking to the places where the links are written! That saved me quite a bit of time. And thanks also for pointing out the Thanks! |
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
|
I've updated |
Komyyy
left a comment
There was a problem hiding this comment.
Thank you!
Speaking from my experience, people new to Lean or Mathlib will first want to look up definitions, so I think keeping it as Subfield is fine.
|
The reason I ask is that bors r+ |
This PR fixes a few dead links on the library overview page: we link to docgen pages for modules, rather than a specific declaration there. But those links still used the mathlib3 naming conventions; update to mathlib4. Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
|
Build failed: |
|
Not sure what happened here, it just says the post-build job was skipped? I'm going to retry. bors r+ |
This PR fixes a few dead links on the library overview page: we link to docgen pages for modules, rather than a specific declaration there. But those links still used the mathlib3 naming conventions; update to mathlib4. Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
|
Build failed: |
|
Ah, this ran into the issue that #35389 fixed. Let's try again. bors r+ |
This PR fixes a few dead links on the library overview page: we link to docgen pages for modules, rather than a specific declaration there. But those links still used the mathlib3 naming conventions; update to mathlib4. Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
|
Pull request successfully merged into master. Build succeeded:
|
This PR fixes a few dead links on the library overview page: we link to docgen pages for modules, rather than a specific declaration there. But those links still used the mathlib3 naming conventions; update to mathlib4.