[Merged by Bors] - chore: support revised nightly toolchains (nightly-YYYY-MM-DD-revK)#35220
Closed
[Merged by Bors] - chore: support revised nightly toolchains (nightly-YYYY-MM-DD-revK)#35220
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PR summary c72b0ec472Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
github-actions
bot
added
the
CI
github-merge-queue bot
pushed a commit
to leanprover/lean4
that referenced
this pull request
Feb 13, 2026
…12461) This PR adds support for manually re-releasing nightlies when a build issue or critical fix requires it. When a `workflow_dispatch` triggers the nightly release job and a `nightly-YYYY-MM-DD` tag already exists, the CI now creates `nightly-YYYY-MM-DD-rev1` (then `-rev2`, etc.) instead of silently skipping. ### Lake `ToolchainVer` - Extend `ToolchainVer.nightly` with an optional `rev : Option Nat` field - Parse `-revK` suffixes from nightly tags in `ofString` - Ordering: `nightly-YYYY-MM-DD` < `nightly-YYYY-MM-DD-rev1` < `-rev2` < `nightly-YYYY-MM-DD+1` - Round-trip: `toString (ofString s) == s` for both variants ### CI workflow - "Set Nightly" step probes existing tags on `workflow_dispatch` to find next available `-revK` - Scheduled nightlies retain existing behavior (skip if commit already tagged) - Changelog grep updated from `nightly-[-0-9]*` to `nightly-[^ ,)]*` to match `-revK` suffixes ### `lean-bisect` - Updated `NIGHTLY_PATTERN` regex, sort key, error messages, and help text ### Companion PRs - leanprover-community/mathlib4#35220: update `nightly_bump_and_merge.yml` tag grep and `nightly_detect_failure.yml` warning message - leanprover-community/leanprover-community.github.io#787: update `tags_and_branches.md` documentation 🤖 Prepared with Claude Code Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
I'm merging this one myself, see #mathlib reviewers > requests for speedy review/delegation @ 💬 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
…35220) This PR updates nightly workflow scripts to handle revised nightly toolchains (`nightly-YYYY-MM-DD-revK`). When multiple nightlies are released for the same date, the revision suffix ensures correct ordering and matching in tag grep patterns, version extraction regexes, and deduplication checks. Changes: - `nightly_bump_and_merge.yml`: update tag grep pattern and use `sort -rV` for correct version ordering - `nightly_detect_failure.yml`: update JS/Python regexes and warning message to handle `-revK` suffix Companion to leanprover/lean4#12461 🤖 Prepared with Claude Code
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
kim-em
added a commit
to kim-em/mathlib4
that referenced
this pull request
Feb 14, 2026
…eanprover-community#35220) This PR updates nightly workflow scripts to handle revised nightly toolchains (`nightly-YYYY-MM-DD-revK`). When multiple nightlies are released for the same date, the revision suffix ensures correct ordering and matching in tag grep patterns, version extraction regexes, and deduplication checks. Changes: - `nightly_bump_and_merge.yml`: update tag grep pattern and use `sort -rV` for correct version ordering - `nightly_detect_failure.yml`: update JS/Python regexes and warning message to handle `-revK` suffix Companion to leanprover/lean4#12461 🤖 Prepared with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates nightly workflow scripts to handle revised nightly toolchains (
nightly-YYYY-MM-DD-revK). When multiple nightlies are released for the same date, the revision suffix ensures correct ordering and matching in tag grep patterns, version extraction regexes, and deduplication checks.Changes:
nightly_bump_and_merge.yml: update tag grep pattern and usesort -rVfor correct version orderingnightly_detect_failure.yml: update JS/Python regexes and warning message to handle-revKsuffixCompanion to leanprover/lean4#12461
🤖 Prepared with Claude Code