Skip to content

feat(MulAction): add a SMulDistribClass instance for subgroups#35371

Open
xroblot wants to merge 3 commits intoleanprover-community:masterfrom
xroblot:instmulaction
Open

feat(MulAction): add a SMulDistribClass instance for subgroups#35371
xroblot wants to merge 3 commits intoleanprover-community:masterfrom
xroblot:instmulaction

Conversation

@xroblot
Copy link
Collaborator

@xroblot xroblot commented Feb 15, 2026


Open in Gitpod

@xroblot xroblot added the bench-after-CI Once the PR passes CI, comment `!bench` on the PR label Feb 15, 2026
@github-actions
Copy link

github-actions bot commented Feb 15, 2026

PR summary 2b9cd2f090

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ smulDistribClass

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 15, 2026
@xroblot
Copy link
Collaborator Author

xroblot commented Feb 16, 2026

!bench

@leanprover-radar
Copy link

leanprover-radar commented Feb 16, 2026

Benchmark results for fc4b136 against 2b9cd2f are in! @xroblot

  • 🟥 build//instructions: +7.0G (+0.00%)

No significant changes detected.

@xroblot xroblot removed the bench-after-CI Once the PR passes CI, comment `!bench` on the PR label Feb 16, 2026
@xroblot
Copy link
Collaborator Author

xroblot commented Feb 16, 2026

!bench

@leanprover-radar
Copy link

leanprover-radar commented Feb 16, 2026

Benchmark results for 50a6a6c against 2b9cd2f are in! @xroblot

  • 🟥 build//instructions: +13.2G (+0.01%)

Small changes (1🟥)

  • 🟥 build/module/Mathlib.Util.ParseCommand//instructions: +128.5M (+5.16%) (reduced significance based on absolute threshold)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants