Skip to content

[Merged by Bors] - ci: Relax cache upload gating to upload cache artifacts from non-success builds#35390

Closed
marcelolynch wants to merge 2 commits intoleanprover-community:masterfrom
marcelolynch:2026/02/UploadCacheOnFailure
Closed

[Merged by Bors] - ci: Relax cache upload gating to upload cache artifacts from non-success builds#35390
marcelolynch wants to merge 2 commits intoleanprover-community:masterfrom
marcelolynch:2026/02/UploadCacheOnFailure

Conversation

@marcelolynch
Copy link
Contributor

Fixing an issue caught by @bryangingechen. We want to upload the build artifacts on failure also, so we run the cache job iff we had some artifacts to stage (and try to stage stuff whenever we had 'some' build)

@github-actions
Copy link

PR summary 3bbc5c706c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Feb 16, 2026
Copy link
Contributor

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this will be easier to merge after #35389 goes in.

@bryangingechen
Copy link
Contributor

#35389 is now on the queue, and there is a zulip thread about the issue this is fixing at #mathlib4 > New CI cache workflow not working properly @ 💬, so I will put this in the same batch.

Thanks!
bors r+

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Feb 16, 2026
mathlib-bors bot pushed a commit that referenced this pull request Feb 16, 2026
…ess builds (#35390)

Fixing an issue caught by @bryangingechen. We want to upload the build artifacts on failure also, so we run the cache job iff we had some artifacts to stage (and try to stage stuff whenever we had 'some' build)
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 16, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title ci: Relax cache upload gating to upload cache artifacts from non-success builds [Merged by Bors] - ci: Relax cache upload gating to upload cache artifacts from non-success builds Feb 16, 2026
@mathlib-bors mathlib-bors bot closed this Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants