[Merged by Bors] - ci: Relax cache upload gating to upload cache artifacts from non-success builds#35390
Closed
marcelolynch wants to merge 2 commits intoleanprover-community:masterfrom
Closed
Conversation
PR summary 3bbc5c706cImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
bryangingechen
approved these changes
Feb 16, 2026
Contributor
bryangingechen
left a comment
There was a problem hiding this comment.
LGTM, but this will be easier to merge after #35389 goes in.
Contributor
|
#35389 is now on the queue, and there is a zulip thread about the issue this is fixing at #mathlib4 > New CI cache workflow not working properly @ 💬, so I will put this in the same batch. Thanks! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2026
…ess builds (#35390) Fixing an issue caught by @bryangingechen. We want to upload the build artifacts on failure also, so we run the cache job iff we had some artifacts to stage (and try to stage stuff whenever we had 'some' build)
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing an issue caught by @bryangingechen. We want to upload the build artifacts on failure also, so we run the cache job iff we had some artifacts to stage (and try to stage stuff whenever we had 'some' build)