Skip to content

feat(Geometry/Manifold): API for extended coordinate changes#35391

Open
peabrainiac wants to merge 3 commits intoleanprover-community:masterfrom
peabrainiac:extCoordChange
Open

feat(Geometry/Manifold): API for extended coordinate changes#35391
peabrainiac wants to merge 3 commits intoleanprover-community:masterfrom
peabrainiac:extCoordChange

Conversation

@peabrainiac
Copy link
Collaborator

Introduce a definition I.extendCoordChange e e' for what previously appeared in lemmas as (e.extend I).symm ≫ e'.extend I, and provide some more API lemmas. Split out from #33189.


Open in Gitpod

@peabrainiac peabrainiac added the t-differential-geometry Manifolds etc label Feb 16, 2026
@github-actions
Copy link

PR summary 3bbc5c706c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.OpenPartialHomeomorph.extend_image_source_inter
+ contDiffOn_extendCoordChange
+ contDiffOn_extendCoordChange_symm
+ contDiffWithinAt_extendCoordChange
+ contDiffWithinAt_extendCoordChange'
+ extendCoordChange
+ extendCoordChange_source
+ extendCoordChange_source_mem_nhdsWithin
+ extendCoordChange_source_mem_nhdsWithin'
+ extendCoordChange_symm
+ extendCoordChange_target
+ isInvertible_fderivWithin_extendCoordChange
+ uniqueDiffOn_extendCoordChange_source
+ uniqueDiffOn_extendCoordChange_target
- extend_image_source_inter

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (2.00, 0.00)
Current number Change Type
4858 2 exceptions for the docPrime linter

Current commit c9d9f727e4
Reference commit 3bbc5c706c

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg
Copy link
Contributor

grunweg commented Feb 16, 2026

I'm wondering if extendCoordChange should be an abbrev and not a def. We don't want to really encapsulate that definition, do we? What do you think?

@grunweg
Copy link
Contributor

grunweg commented Feb 16, 2026

Thanks for making the PR! I'll need a more awake moment than right now to double-check the diff (which is sadly not as readable...), but this mostly looks straightforward. Let me get a second opinion on the above question, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants