feat: [lean4web] abstract the implementation of infoview as a webview#567
Open
joneugster wants to merge 1 commit intoleanprover:masterfrom
Open
feat: [lean4web] abstract the implementation of infoview as a webview#567joneugster wants to merge 1 commit intoleanprover:masterfrom
joneugster wants to merge 1 commit intoleanprover:masterfrom
Conversation
Contributor
Author
|
updated version of #495 |
This was referenced Jan 13, 2025
joneugster
force-pushed
the
webview2
branch
2 times, most recently
from
8d084cf to
e544ad0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pure refactoring. The behavior of the code has not changed. But this setup allows us to inject an iframe infoview implementation instead of the webview implementation.