Skip to content

Bump and rename sslcontext-kicktart to ayza #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump and rename sslcontext-kicktart to ayza #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mtls-examples/java/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ If you want to run this template, you will need a set of credentials from Lean T
1. Again, download the file and unzip it.

At this point, there are two options:
1. Create the `keystore` required to make a secure connection in memory (`src/main/java/me/lean/tech/dev/apacheclient/MtlsUsingApacheClient.java`), using a [helper library](https://github.com/Hakky54/sslcontext-kickstart) to read lean certificates:
1. Create the `keystore` required to make a secure connection in memory (`src/main/java/me/lean/tech/dev/apacheclient/MtlsUsingApacheClient.java`), using a [helper library](https://github.com/Hakky54/ayza) to read lean certificates:
Copy link

@gemini-code-assist gemini-code-assist bot Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There appears to be a typo in the file path. The path me/lean/tech/dev/apacheclient/MtlsUsingApacheClient.java should likely be me/leantech/dev/apacheclient/MtlsUsingApacheClient.java to match the package name me.leantech.dev.apacheclient.

Suggested change
1. Create the `keystore` required to make a secure connection in memory (`src/main/java/me/lean/tech/dev/apacheclient/MtlsUsingApacheClient.java`), using a [helper library](https://github.com/Hakky54/ayza) to read lean certificates:
1. Create the `keystore` required to make a secure connection in memory (`src/main/java/me/leantech/dev/apacheclient/MtlsUsingApacheClient.java`), using a [helper library](https://github.com/Hakky54/ayza) to read lean certificates:

1. In the [application.properties](src/main/resources/application.properties),
1. replace the path of certificates `<ABSOLUTE_FOLDER_PATH_WHERE_CERTIFICATES_ARE_STORED>` with the absolute path of `certs` folder
2. replace the mock certificates filenames:
Expand Down
8 changes: 4 additions & 4 deletions mtls-examples/java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@
</dependency>
<dependency>
<groupId>io.github.hakky54</groupId>
<artifactId>sslcontext-kickstart</artifactId>
<version>7.2.0</version>
<artifactId>ayza</artifactId>
<version>10.0.0</version>
Copy link

@gemini-code-assist gemini-code-assist bot Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and ensure version consistency across ayza artifacts, consider defining the version as a Maven property. You can add <ayza.version>10.0.0</ayza.version> to your <properties> section and use ${ayza.version} for all ayza dependencies.

Suggested change
<version>10.0.0</version>
<version>${ayza.version}</version>

</dependency>
<dependency>
<groupId>io.github.hakky54</groupId>
<artifactId>sslcontext-kickstart-for-pem</artifactId>
<version>7.2.0</version>
<artifactId>ayza-for-pem</artifactId>
<version>10.0.0</version>
Copy link

@gemini-code-assist gemini-code-assist bot Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similarly, use the Maven property here to maintain version consistency.

Suggested change
<version>10.0.0</version>
<version>${ayza.version}</version>

</dependency>

<!-- START: INCLUDE THESE WHEN USING SPRING BOOT-->
Expand Down
2 changes: 1 addition & 1 deletion mtls-examples/java/src/main/java/me/leantech/dev/apacheclient/MtlsUsingApacheClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import lombok.extern.slf4j.Slf4j;
import nl.altindag.ssl.util.CertificateUtils;
import nl.altindag.ssl.util.PemUtils;
import nl.altindag.ssl.pem.util.PemUtils;
import org.apache.http.HttpEntity;
import org.apache.http.HttpHeaders;
import org.apache.http.client.methods.CloseableHttpResponse;
Expand Down