Skip to content

Conversation

@aobolensk
Copy link
Member

No description provided.

@aobolensk aobolensk requested review from allnes and Copilot May 12, 2025 21:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to enable USE_LATEX=ON by default by removing the explicit flag from build commands so that the default behavior is applied.

  • The README.md has been updated to remove the explicit -D USE_LATEX=ON flag from the build instructions.
  • The GitHub Actions workflows have been updated to remove the flag from the cmake build commands, aligning the CI configuration with the intended default behavior.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
README.md Removed the -D USE_LATEX=ON flag from the build command and instructions.
.github/workflows/main.yml Removed the -D USE_LATEX=ON flag from each cmake build command in CI jobs.
Files not reviewed (1)
  • CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/main.yml:27

  • Removing the -D USE_LATEX=ON flag from the CI build commands conflicts with the PR title. Verify that the default behavior truly enables LaTeX and update the CI documentation or commands accordingly.
cmake -G Ninja -S . -B build

@allnes allnes merged commit 3947004 into learning-process:master May 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants