-
Notifications
You must be signed in to change notification settings - Fork 8
Ruby 3 upgrade #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
paranoicsan
wants to merge
158
commits into
master
Choose a base branch
from
ruby-3-upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Ruby 3 upgrade #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires attention. See https://github.com/railsware/js-routes/blob/master/VERSION_2_UPGRADE.md for details. Upgrade needed for compatibility for Ruby 3.2
Removed `Lcms::Engine::DocumentPresenter#short_url` method.
Also upgrade acts-as-taggable-on to v9.0 for Rails 7 support.
And move it to `development dependencies`
1. Updated universal Dockerfile 2. Remove legacy images and styles 3. Introduce new way ReactJS components are rendered - Admin::ReactComponentsHelper#render_component 4. Cleanup unused locale keys, controllers, services and view
Trying to make it work.
- start container ONLY - start container AND install gems ONLY - start container, install gems AND launch yarn
This solves wrong paths errors
0537fd6 to
c087cea
Compare
fixed parsing tables with thead
2f11d45 to
fbec3b4
Compare
fbec3b4 to
dae31c0
Compare
- Update some gems, including rubocop. Refactoring code for that. - Bump PostgreSQL to 15 in Dockerfile
- Added some steep directives to correctly handle empty collection declaration. - Updated RBS declarations
Bump Ruby to 3.2.9
Changes made: - Update Ruby version to 3.3.8 in .ruby-version, Dockerfile, and related docs - Update Bundler version to 2.5.22 in setup scripts and Dockerfile - Update wicked_pdf and other gem dependencies in Gemfile.lock - Adjust docker-compose.yml and README.md to reference new Ruby version - Update CHANGELOG.md to reflect Ruby version bump
Bump Ruby version to 3.3.8 and update dependencies
Update Ruby version and project configuration Changes made: - Updated .codeship/rubygems-version to a new RubyGems version - Updated .ruby-version to a new Ruby version - Updated CHANGELOG.md with recent changes - Modified Dockerfile for updated environment or dependencies - Updated README.md documentation - Changed docker-compose.yml for service configuration - Updated lcms-engine.gemspec for gem specification changes
Bump ruby to 3.3.9 and update gems
350b107 to
795352d
Compare
795352d to
028786e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: