fix(api-gateway): graphql relay connection findAll do not work #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boomspeed94
changed the title
boomspeed94
force-pushed
the
fix/api-gateway-graphql-relay-findAll
branch
from
49a1a29 to
04e3c1d
Compare
tiendq
reviewed
Nov 25, 2020
tiendq
reviewed
Nov 25, 2020
tiendq
reviewed
Nov 25, 2020
Codecov Report
@@ Coverage Diff @@
## develop #126 +/- ##
===========================================
- Coverage 95.16% 95.01% -0.15%
===========================================
Files 69 70 +1
Lines 1096 1144 +48
Branches 129 145 +16
===========================================
+ Hits 1043 1087 +44
Misses 53 53
- Partials 0 4 +4
Continue to review full report at Codecov.
|
manh-vv
reviewed
Dec 11, 2020
| }; | ||
|
|
||
| const resp = convertCursorToOffet(entityName, input); | ||
| expect(resp.first).toBe(3); |
Member
There was a problem hiding this comment.
I don't really understand why this is 3 but not 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.