Skip to content

Adds null checks to prevent crashes #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ErikDahlinghaus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds null checks to prevent crashes #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion addons/timers/buffs.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,10 @@ local function HandleAction(act)

if not party then return end

if not act then return end
if not act.targets[1] then return end
if not act.targets[1].actions[1] then return end
if not act.targets[1].actions[1].message then return end
local message = act.targets[1].actions[1].message

local serverId = party:GetMemberServerId(0)
Expand Down Expand Up @@ -582,7 +586,9 @@ local function UpdateBuffs(timers)

local timer_name = v.name
if (t_entity and t_entity.ServerId) ~= (a_entity and a_entity.ServerId) then
timer_name = ("%s (%s)"):fmt(v.name, t_entity.Name)
local entity_name = "Unknown"
if (t_entity and t_entity.Name) then entity_name = t_entity.Name end
timer_name = ("%s (%s)"):fmt(v.name, entity_name)
end

local diff = ((ashita.time.clock()['ms'] - v.o_time) / 1000.0) * 60.0
Expand Down
5 changes: 5 additions & 0 deletions addons/timers/debuffs.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,11 @@ local function ApplyDebuff(target, effect, spell, actor, type, param)
end

local function HandleAction(act)

if not act then return end
if not act.targets[1] then return end
if not act.targets[1].actions[1] then return end
if not act.targets[1].actions[1].message then return end
local message = act.targets[1].actions[1].message

if not ActionIsLocal(act.actor_id) then return end
Expand Down