Added missing extrastyle block to base_post_login.html #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanhulzen-leukeleu
requested review from
153957,
ramonakira,
rvanleeuwen-leukeleu and
wadevries
as code owners
153957
approved these changes
Aug 27, 2025
ramonakira
reviewed
Oct 2, 2025
| <link rel="stylesheet" href="{% static 'admin/css/dark_mode.css' %}"> | ||
| <script src="{% static 'admin/js/theme.js' %}" nonce="{% csp_nonce %}"></script> | ||
| {% endblock %} | ||
| {% block extrastyle %}{% endblock %} |
Member
There was a problem hiding this comment.
Maybe call it extra_head or something so it can be used for anything that could ever be added to the head?
Suggested change
| {% block extrastyle %}{% endblock %} | |
| {% block extra_head %}{% endblock %} |
ramonakira
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if we could add the missing
{% block extrastyle %}that matches the base_per_login.html and Django'sbase_site.html.With this change it would be possible to add an extra stylesheet where we could override the Django default CSS vars to match our own design.