Refactor math CAT to use downex column of corpus#424
Refactor math CAT to use downex column of corpus#424zwatson2001 wants to merge 4 commits intomainfrom
Conversation
| allowedIDs = ['math-intro2']; | ||
| break; | ||
| case 3: | ||
| case 2: |
There was a problem hiding this comment.
Do you think at some point we can make this generic enough where this is config driven and hard coded like right now? Ideally, we will be able to switch the blocks around, along with filtering of ids etc via some external config which then this code reads and builds the task. What do you think?
There was a problem hiding this comment.
This kind've a special case, because the math cat is organized into 3 blocks but the non-CAT version has more blocks. Each block has a generic instruction at the beginning saying "Here's a new kind of question", but because the corpus has one for each block in the non-CAT version, the CAT has to filter some of them out since it has fewer blocks. We could maybe add a corpus column cat_only so that it isn't hard coded like this? I'm not sure what the best solution is
asengupta3
left a comment
There was a problem hiding this comment.
LGTM! Just one future suggestion probably worth discussing at some point.
This PR makes changes to the math timeline so that it is consistent with the other new downex tasks, using the
downexcolumn of the corpus for all downex trials rather than relying on a negative difficulty value for instructions andblock_index=3for test trials.