Depends on #151 Edit functionality for transactions feed#152
Depends on #151 Edit functionality for transactions feed#152mementablog wants to merge 10 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds transaction editing capabilities to the transactions feed view, implementing edit, duplicate, copy to next month, and delete functionality using a shared modal pattern consistent with the calendar view.
Key changes:
- Adds a reusable SearchForm component for transaction filtering
- Creates comprehensive feature documentation for the TransactionsFeedView
- Updates README to include links to the new documentation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/inputs/SearchForm.vue | New reusable search component with floating labels and clear functionality |
| frontend/src/components/inputs/SearchForm.stories.ts | Storybook stories for the SearchForm component |
| features_documentation/transactions/TransactionsFeedView.md | Comprehensive feature documentation for the transactions feed view |
| features_documentation/transactions/TransactionsFeedView-QuickReference.md | Quick reference guide for developers |
| features_documentation/transactions/TransactionsFeedView-Implementation.md | Detailed implementation guide for developers |
| README.md | Updated to include links to new feature documentation |
| component: SearchForm, | ||
| tags: ['stable', 'testable'], | ||
|
|
||
|
|
There was a problem hiding this comment.
Extra blank line at line 10 should be removed to maintain consistent spacing in the meta object definition.
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Multiple trailing blank lines should be removed. The file should end with a single newline.
| function clearAllFilters() { | ||
| clearSearch(); | ||
| // clearDateRange(); | ||
| emit('clear-all'); | ||
| } |
There was a problem hiding this comment.
The clearAllFilters function is defined but never used since it's commented out in the template. Consider removing this function if it's not needed for the current implementation.
| function clearAllFilters() { | |
| clearSearch(); | |
| // clearDateRange(); | |
| emit('clear-all'); | |
| } |
|
Merged in #153 |
This PR adds:
Uses the same pattern as in calendar view for editing transactions (exact modal)