-
Notifications
You must be signed in to change notification settings - Fork 188
💄 style(ui): fix scrollbar style declarations to apply -webkit-scrollbar pseud classes to Safari
#3971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Finished running flow.
|
||||||||||||
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR adds a changeset file documenting a patch release for the UI package and updates global scrollbar styling to use feature detection with Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Updates to Preview Branch (style/scrollbar-in-safari) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
Check changeset necessityStatus:
Reason:
Changeset (copy & paste):---
"@liam-hq/ui": patch
---
- 💄 fix scrollbar styles so that ::-webkit-scrollbar pseudo classes take effect in Safari |
| /* For browsers that support `scrollbar-*` properties */ | ||
| @supports (scrollbar-color: auto) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend to check the diff with by hiding white spaces
I basically follow this instruction.
Since the latest Safari (v26) supports scrollbar-width property, it prioritize the standard scrollbar styles when scrollbar-width has value other than auto and doesn't refer to -webkit-scrollbar-* pseuds classes. However, it doesn't support the scrollbar-color property yet, so scrollbars used to be displayed with the default color in Safari.
This PR will make the scrollbar-width property declaration be not applied in the Safari, so webkit-scrollbar-* pseud classes will be applied properly.
|
I actually found the other cases to be checked if scrollbar styles work properly from the change of this PR. |
MH4GF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was very educational. Thanks!
Issue
Why is this change needed?
With The current application, the scrollbar style declarations are not applied in Safari.
This PR will fix scrollbar style declarations to apply
-webkit-scrollbarpseude classes to Safari.I also checked the style is applied properly in the latest Chrome and Firefox as like the before.
Summary by CodeRabbit