Skip to content

Conversation

@tnyo43
Copy link
Member

@tnyo43 tnyo43 commented Nov 2, 2025

Issue

  • resolve:

Why is this change needed?

With The current application, the scrollbar style declarations are not applied in Safari.
This PR will fix scrollbar style declarations to apply -webkit-scrollbar pseude classes to Safari.

I also checked the style is applied properly in the latest Chrome and Firefox as like the before.

before after
TableDetail Screenshot 0007-11-02 at 12 11 54 Screenshot 0007-11-02 at 12 12 06
CommandPalette Screenshot 0007-11-02 at 12 11 03 Screenshot 0007-11-02 at 12 11 38

Summary by CodeRabbit

  • Bug Fixes
    • Fixed scrollbar styling to display correctly across all browsers, including Safari

@giselles-ai
Copy link

giselles-ai bot commented Nov 2, 2025

Finished running flow.

Step 1
🟢
On Pull Request OpenedStatus: Success Updated: Nov 2, 2025 3:07am
Step 2
🟢
gpt-5Status: Success Updated: Nov 2, 2025 3:08am
Step 3
🟢
Create Pull Request CommentStatus: Success Updated: Nov 2, 2025 3:08am

@vercel
Copy link

vercel bot commented Nov 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
liam-app Ready Ready Preview Comment Nov 2, 2025 3:13am
liam-assets Ready Ready Preview Comment Nov 2, 2025 3:13am
liam-erd-sample Ready Ready Preview Comment Nov 2, 2025 3:13am
liam-storybook Ready Ready Preview Comment Nov 2, 2025 3:13am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
liam-docs Ignored Ignored Nov 2, 2025 3:13am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 2, 2025

Walkthrough

This PR adds a changeset file documenting a patch release for the UI package and updates global scrollbar styling to use feature detection with @supports, supporting both standard scrollbar properties and WebKit pseudo-elements for improved Safari compatibility.

Changes

Cohort / File(s) Summary
Changeset entry
.changeset/sweet-chicken-stay.md
Documents patch release for @liam-hq/ui with fix for scrollbar styles to enable ::-webkit-scrollbar pseudo-classes in Safari.
Scrollbar styling refactor
frontend/packages/ui/src/styles/globals.css
Replaced universal scrollbar styling with feature-detect approach using @supports. Adds standard scrollbar-color/width branch for compatible browsers, WebKit pseudo-element branch for Safari with width, height, track, and thumb styling. Includes hover state and clarifying comments on property precedence.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Straightforward feature detection implementation with clear separation of standard vs. WebKit fallback paths
  • CSS-only changes with good inline documentation
  • Verify that both feature-detect branches render correctly across target browsers (particularly Safari and standard-compliant browsers)

Possibly related PRs

Suggested labels

Review effort 2/5

Suggested reviewers

  • hoshinotsuyoshi
  • NoritakaIkeda
  • MH4GF
  • FunamaYukina

Poem

🐰 Scrollbars now dance with feature's grace,
Webkit and standards share the space,
Safari smiles at pseudo-classes found,
With @supports guards, smooth styling's bound!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "💄 style(ui): fix scrollbar style declarations to apply -webkit-scrollbar pseud classes to Safari" is directly related to the main change in the pull request. The changeset and CSS modifications specifically address fixing scrollbar styles so that the -webkit-scrollbar pseudo-classes take effect in Safari, which is precisely what the title conveys. The title uses a conventional commit format with appropriate scope and is sufficiently clear and specific for a teammate to understand the primary change when scanning commit history. Note: there is a minor typo ("pseud" instead of "pseudo"), but this does not affect the overall clarity or accuracy of the description.
Description Check ✅ Passed The pull request description follows the required template structure with both specified sections present: "Issue" and "Why is this change needed?". The "Why is this change needed?" section is well-populated with a clear explanation of the problem (scrollbar styles not applying in Safari), the solution (implementing -webkit-scrollbar pseudo-classes), and comprehensive verification evidence including before/after screenshots across TableDetail and CommandPalette components, plus confirmation of compatibility with Chrome and Firefox. However, the "Issue" section's "resolve:" field is incomplete, containing only the label without an issue reference or number. Since the primary explanation and rationale are thoroughly documented with visual proof, and the incomplete issue reference is a secondary metadata field rather than critical context, the description provides sufficient clarity for the change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch style/scrollbar-in-safari

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@supabase
Copy link

supabase bot commented Nov 2, 2025

Updates to Preview Branch (style/scrollbar-in-safari) ↗︎

Deployments Status Updated
Database Sun, 02 Nov 2025 03:09:32 UTC
Services Sun, 02 Nov 2025 03:09:32 UTC
APIs Sun, 02 Nov 2025 03:09:32 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Sun, 02 Nov 2025 03:09:42 UTC
Migrations Sun, 02 Nov 2025 03:09:46 UTC
Seeding Sun, 02 Nov 2025 03:09:46 UTC
Edge Functions Sun, 02 Nov 2025 03:09:46 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

@giselles-ai
Copy link

giselles-ai bot commented Nov 2, 2025

Check changeset necessity

Status:

  • REQUIRED (already satisfied)

Reason:

  • Affects @liam-hq/ui, which is a target package that requires a changeset for user-facing changes.
  • The change is user-facing: scrollbar appearance/behavior is corrected in Safari.
  • This is a bug fix (visual behavior), which qualifies for a patch release under the guide.
  • A valid changeset file exists in this PR: .changeset/sweet-chicken-stay.md targeting @liam-hq/ui with patch.

Changeset (copy & paste):

---
"@liam-hq/ui": patch
---

- 💄 fix scrollbar styles so that ::-webkit-scrollbar pseudo classes take effect in Safari

Comment on lines +11 to +12
/* For browsers that support `scrollbar-*` properties */
@supports (scrollbar-color: auto) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to check the diff with by hiding white spaces

I basically follow this instruction.
Since the latest Safari (v26) supports scrollbar-width property, it prioritize the standard scrollbar styles when scrollbar-width has value other than auto and doesn't refer to -webkit-scrollbar-* pseuds classes. However, it doesn't support the scrollbar-color property yet, so scrollbars used to be displayed with the default color in Safari.

This PR will make the scrollbar-width property declaration be not applied in the Safari, so webkit-scrollbar-* pseud classes will be applied properly.

@tnyo43
Copy link
Member Author

tnyo43 commented Nov 2, 2025

I actually found the other cases to be checked if scrollbar styles work properly from the change of this PR.
However, I'm not familiar with these features, so I appreciate if you would help me to check them 🙇

@tnyo43 tnyo43 marked this pull request as ready for review November 2, 2025 03:41
@tnyo43 tnyo43 requested a review from a team as a code owner November 2, 2025 03:41
@tnyo43 tnyo43 requested review from MH4GF, NoritakaIkeda, junkisai and sasamuku and removed request for a team November 2, 2025 03:41
Copy link
Member

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was very educational. Thanks!

@MH4GF MH4GF added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 253bc47 Nov 4, 2025
35 checks passed
@MH4GF MH4GF deleted the style/scrollbar-in-safari branch November 4, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants