Skip to content

Fix PETSc 3.24 deprecated warnings #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

Fix PETSc 3.24 deprecated warnings #4291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/solvers/petsc_linear_solver.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,8 +773,13 @@ LinearConvergenceReason PetscLinearSolver<T>::get_converged_reason() const

switch(reason)
{
#if PETSC_VERSION_LESS_THAN(3,24,0)
case KSP_CONVERGED_RTOL_NORMAL : return CONVERGED_RTOL_NORMAL;
case KSP_CONVERGED_ATOL_NORMAL : return CONVERGED_ATOL_NORMAL;
#else
case KSP_CONVERGED_RTOL_NORMAL_EQUATIONS : return CONVERGED_RTOL_NORMAL;
Copy link
Member Author

@jwpeterson jwpeterson Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roystgnr the error on the Min gcc (PETSc 3.22.1) build refers to line 780, a line that should only be seen by PETSc >= 3.24.0. Do you know if there's anything different about the build environment for that recipe that would somehow cause us to configure against one PETSc version and then actually build against another??

case KSP_CONVERGED_ATOL_NORMAL_EQUATIONS : return CONVERGED_ATOL_NORMAL;
#endif
case KSP_CONVERGED_RTOL : return CONVERGED_RTOL;
case KSP_CONVERGED_ATOL : return CONVERGED_ATOL;
case KSP_CONVERGED_ITS : return CONVERGED_ITS;
Expand Down