[EMTC] Implemented Major Output Calculations + Motor Torque Graph#22
[EMTC] Implemented Major Output Calculations + Motor Torque Graph#22htran381 wants to merge 5 commits intolibhal-google:mainfrom
Conversation
htran381
commented
Jun 5, 2023
htran381
commented
- Implemented Max Torque, Max Current, Max Power, RPM @ Limited, and Power @ Limited Outputs.
- Added Motor Torque Graph via Plotly
- Added Missing Input: Target Torque
- Added in missing Supply Voltage input - Corrected input & output unit labels - Implemented equations from DMS website for outputs - Attempted to reconfigure "Math in Action" for new equations
+Motor Torque Graph
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks Hannah! You'll need to sign the google CLA before we can evaluate your PR. |
|
I've signed the CLA and it won't give a passing check despite the amount of times I've had this PR rescanned. Would I need to close this PR and do another one for it to work? |
Sounds good. Are you sure you are signing the CLA with the email associated with your github? If not, you'll need to add that email to your github. |
|
Yup! I made sure my github email is the same on the CLA. |
|
I can work with you to figure out the CLA issue whenever you have time. Message me on discord your availability. |
2 participants
