feat: advance connection management checkout #1092
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
@seetadev @sumanjeet0012 @acul71 This PR is backed up from the original #1018 which got corrupt after resolving the commits. Raised this after the latest main branch, and the only difference in this branch is the git commit history.Note The failing interop tests are due to |
…load The test creates 499 connections but the default max_connections is 300, causing connection management to reject/prune connections. This fix: - Configures host_a's swarm to allow enough connections (509) for all dummy peers - Configures dummy hosts' swarms to allow more incoming connections - Increases wait time from 0.5s to 1.0s for identify push to complete - Fixes line length issues to pass linting Fixes test_all_peers_receive_identify_push_with_semaphore_under_high_peer_load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #553 (Implement Advanced Connection Management Features)
How was it fixed?
Implemented a complete connection management system matching JavaScript libp2p's capabilities:
Core Components Added:
/dns4/,/dns6/, and/dnsaddr/multiaddrs with cachingConfiguration Enhancements:
Extended
ConnectionConfigwith 17+ new options matching JS libp2p defaults:max_connections,max_parallel_dials, etc.)dial_timeout,inbound_upgrade_timeout, etc.)reconnect_retries,reconnect_backoff_factor, etc.)allow_list,deny_listwith CIDR support)Integration:
SwarmclassSummary of approach: