wayland: Remove the hack to unset limits before entering fullscreen #14039
+568
−226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kontrabant
force-pushed
the
wayland_libdecor_order
branch
2 times, most recently
from
e1df180 to
940d919
Compare
Collaborator
|
Should this go in for 3.4? |
Contributor
Author
|
It can't go in before the backported GNOME fixes are merged, or things will break for users on older versions. |
Contributor
Author
|
Just to note, the upstream changes are merged, and should ship in 48.7 later in November. |
Wayland is sometimes at-odds with clients that want to enforce an aspect ratio or min/max window size, as certain window states have dimensions that either must be obeyed (maximized), or will give terrible results if they aren't (tiled). Use viewports and/or a masking subsurface to handle cases where surfaces are unable to match the exact window size. The masking system also allows for switching the emulated fullscreen modes to aspect-correct by default, as it will handle masking non-native aspect ratios on compositors that don't automatically mask around fullscreen windows.
Kontrabant
force-pushed
the
wayland_libdecor_order
branch
from
940d919 to
3f84db6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The associated surface commit causes a warning (previously a crash) on GNOME + libdecor when clients enter fullscreen before the initial buffer commit.
This was only ever needed on GNOME, and is fixed in GNOME 49, but is waiting on upstream backports: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4681 and https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4680
Fixes #14032