Add Dual Governance to protocol scratch deploy #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandstone-ag
force-pushed
the
feat/dg-scratch-deployment
branch
from
466b5f6 to
e60b63d
Compare
sandstone-ag
force-pushed
the
feat/dg-scratch-deployment
branch
from
e60b63d to
d7844ec
Compare
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: e54cd83 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
arwer13
requested changes
Sep 16, 2025
Contributor
arwer13
left a comment
arwer13
left a comment
There was a problem hiding this comment.
Thanks for the work!
I see these follow ups:
-
Rebase on up-to-date vaults branch #1287
-
Add integration which verifies dual governance upgrade pass (for any dummy one). Boilerplates for the voting script (contract) is in the vaults branch as well. At the moment it won't work because proper roles distribution (in LidoTemplate.sol) is missing.
-
Make sure no-DG setup is also operational. It is at the moment, but after the roles tinkering there gonna be two Aragon roles configuration. Actually, I'm not 100% sure we optional DG installation is worth the effort, but likely it is. To simplify we can split LidoTemplate into LidoTemplateBase, LidoTemplate and LidoTemplateWithDG - it seems not much work. But for the integration tests and for the utility contracts/scripts which do an upgrade there must be two setups to support in this case. Wdyt @tamtamchik ?
| networkState[Sk.dualGovernanceConfig].dual_governance.sanity_check_params.min_withdrawals_batch_size, | ||
| }, | ||
| }, | ||
| dual_governance_config_provider: { |
Contributor
There was a problem hiding this comment.
Just
Suggested change
| dual_governance_config_provider: { | |
| dual_governance_config_provider: networkState[Sk.dualGovernanceConfig].dual_governance_config_provider |
here and similar places, why not?
| } | ||
| } | ||
|
|
||
| async function runCommand(command: string, workingDirectory: string) { |
Contributor
There was a problem hiding this comment.
runCommand duplicates here and in dg-installation.ts . May move to lib/subprocess.ts or some other lib file
Member
Agree, we need no-DG setup also for some devnets to simplify operational work when DG not related to the scope of changes. |
tamtamchik
added
infrastructure
sandstone-ag
force-pushed
the
feat/dg-scratch-deployment
branch
from
2e73c48 to
4b6dc09
Compare
sandstone-ag
force-pushed
the
feat/dg-scratch-deployment
branch
from
c732df7 to
ea79118
Compare
sandstone-ag
force-pushed
the
feat/dg-scratch-deployment
branch
2 times, most recently
from
fb6aefd to
673d745
Compare
sandstone-ag
force-pushed
the
feat/dg-scratch-deployment
branch
2 times, most recently
from
8b44c84 to
b4e43e0
Compare
sandstone-ag
force-pushed
the
feat/dg-scratch-deployment
branch
from
b4e43e0 to
d8f4ffd
Compare
sandstone-ag
force-pushed
the
feat/dg-scratch-deployment
branch
from
b791b52 to
e54cd83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Dual Governance to protocol scratch deploy
Context
After the deployment of Dual Governance on Lido mainnet we need to add the DG deployment to protocol scratch deploy routine.
Problem
DAO-654
After the deployment of Dual Governance on Lido mainnet we need to add the DG deployment to protocol scratch deploy routine.
Solution
Added DG to scratch deployment