Skip to content

Conversation

@il-sairamg
Copy link
Contributor

Skip commented-out computed methods so the reactivity-guard plugin doesn’t crash.
Use brace matching instead of regex to parse computed blocks safely.

@github-actions
Copy link

Test Results: ✅ PASSED

Run at: 2026-01-21T14:05:23.529Z

Summary:
passed: 962 failed: 0 of 962 tests

@github-actions
Copy link

Test Results: ✅ PASSED

Run at: 2026-01-23T05:38:56.385Z

Summary:
passed: 311 failed: 0 of 311 tests

@github-actions
Copy link

Test Results: ✅ PASSED

Run at: 2026-01-23T07:26:30.405Z

Summary:
passed: 311 failed: 0 of 311 tests

Copy link
Collaborator

@michielvandergeest michielvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michielvandergeest michielvandergeest merged commit f963e23 into lightning-js:dev Jan 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants