Skip to content

only processSome if there are updates, add PQ check #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wouterlucas merged 2 commits into from
Jan 21, 2026
Merged

only processSome if there are updates, add PQ check #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ed54cd
only processSome if there are updates, add PQ check
chiefcll Jan 21, 2026
d978b7a
truth check
chiefcll Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/CoreTextureManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ export class CoreTextureManager extends EventEmitter {
}

public hasUpdates(): boolean {
return this.uploadTextureQueue.length > 0;
return this.uploadTextureQueue.length > 0 || this.priorityQueue.length > 0;
}

/**
Expand Down
12 changes: 7 additions & 5 deletions src/core/Stage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,11 +471,13 @@ export class Stage {

// Process some textures asynchronously but don't block the frame
// Use a background task to prevent frame drops
this.txManager
.processSome(this.options.textureProcessingTimeLimit)
.catch((err) => {
console.error('Error processing textures:', err);
});
if (this.txManager.hasUpdates() === true) {
this.txManager
.processSome(this.options.textureProcessingTimeLimit)
.catch((err) => {
console.error('Error processing textures:', err);
});
}

// Reset render operations and clear the canvas
renderer.reset();
Expand Down