Skip to content

cache key value for shader nodes #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chiefcll wants to merge 2 commits into
base: main
Choose a base branch
from
Open

cache key value for shader nodes #725

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91f810d
cache key value for shader nodes
chiefcll Jan 21, 2026
477ed29
change to private
chiefcll Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/core/renderers/CoreShaderNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ export class CoreShaderNode<Props extends object = Record<string, unknown>> {
protected node: CoreNode | null = null;
readonly time: CoreShaderType['time'] = undefined;
update: (() => void) | undefined = undefined;
private _valueKeyCache = '';
private _valueKeyDirty = true;
private _lastW = 0;
private _lastH = 0;

constructor(
readonly shaderKey: string,
Expand Down Expand Up @@ -141,6 +145,7 @@ export class CoreShaderNode<Props extends object = Record<string, unknown>> {
} else {
this.resolvedProps![key] = value;
}
this._valueKeyDirty = true;

if (this.update !== undefined && this.node !== null) {
this.node.setUpdateType(UpdateType.RecalcUniforms);
Expand All @@ -158,12 +163,27 @@ export class CoreShaderNode<Props extends object = Record<string, unknown>> {
}

createValueKey() {
if (
this._valueKeyDirty === false &&
this.node !== null &&
this.node.w === this._lastW &&
this.node.h === this._lastH
) {
return this._valueKeyCache;
}

let valueKey = '';
for (const key in this.resolvedProps) {
valueKey += `${key}:${this.resolvedProps[key]!};`;
}
valueKey += `node-width:${this.node!.w}`;
valueKey += `node-height:${this.node!.h}`;

this._valueKeyCache = valueKey;
this._valueKeyDirty = false;
this._lastW = this.node!.w;
this._lastH = this.node!.h;

return valueKey;
}

Expand Down