Refactor/remove render ops #727
Conversation
| bindRenderOp(renderOp: WebGlRenderOp) { | ||
| this.bindBufferCollection(renderOp.buffers); | ||
| this.bindTextures(renderOp.textures); | ||
| const isCoreNode = renderOp instanceof CoreNode; |
There was a problem hiding this comment.
This instanceof check is a bit expensive since there a lot to check in CoreNode. This needs to be replaced by a simpler check
| return (this.stage.renderer as WebGlRenderer).quadBufferCollection; | ||
| } | ||
|
|
||
| get width(): number { |
There was a problem hiding this comment.
don't need these, use get w if you really must, but if its for internal use, avoid using getters and just use props.w / props.h
There was a problem hiding this comment.
That's a lot of overhead. With the change to w / h it wasn't done throughout the code base. So now we face w => width and vice versa and same with height. That requires if statements in a lot of places. If you and the team want to spend the time to make it consistent through out the code base that would allow removing this.
| return this.textureCoords || this.stage.renderer.defaultTextureCoords; | ||
| } | ||
|
|
||
| get quadBufferCollection(): BufferCollection { |
There was a problem hiding this comment.
This is very WebGl specific, handle this in WebGLRenderer.
There was a problem hiding this comment.
CoreNodes are now renderOps.
| return this.props.texture || this.stage.defaultTexture; | ||
| } | ||
|
|
||
| get renderTextureCoords(): TextureCoords | undefined { |
There was a problem hiding this comment.
This is very WebGl specific, handle this in WebGLRenderer.
There was a problem hiding this comment.
Canvas renderer needs this as well
2 participants
Phase 2 - after #726
Removes RenderOps and leaves it on CoreNode. Cleanup property differences between SDF & CoreNode