Fixed an issue preventing the Mod from starting on a Dedicated Server#40
Open
OutCraft-Mods wants to merge 1 commit intolightning2401:mainfrom
Open
Fixed an issue preventing the Mod from starting on a Dedicated Server#40OutCraft-Mods wants to merge 1 commit intolightning2401:mainfrom
OutCraft-Mods wants to merge 1 commit intolightning2401:mainfrom
Conversation
…i.create.foundation.utility.Pair`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to run this mod on a Dedicated Server (not Open-To-Lan, but "real" server jar) results in the crash
The Forge Dedicated Server version of Minecraft does not contain the
icu4jlibrary used on a client, but part of the mod's serverside code depends onicu4jfor thePairclass.This PR replaces all occurrences of
com.ibm.icu.impl.Pairwith the Pair class of Create (com.simibubi.create.foundation.utility.Pair) which exists on a Dedicated Server and is nearly identical to theicu4jone.