Support client_trusts_lsp=true on ldk-node #687
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 I see @tnull was un-assigned. |
martinsaposnic
force-pushed
the
client-trusts-lsp-2
branch
from
a69c91f to
4927b73
Compare
implement changes introduced on lightningdevkit/rust-lightning#3838 as discussed, client_trusts_lsp is a flag set at startup. a new function receive_via_jit_channel_manual_claim is introduced to bolt11 so we allow the client to manually claim a payment (used on tests).
martinsaposnic
force-pushed
the
client-trusts-lsp-2
branch
from
4927b73 to
27dc7b4
Compare
|
With LDK Node including this PR, I got a compilation error and had to add these imports It compiled after that, then I tried to do LSPS2 JIT onboarding, but it failed ("route not found" from the client side). Note sure if that's an issue with this PR or me. |
|
I’m sorry. This should have been a draft. I just cherry picked the commits from the old PR. I will make CI pass in the next few days |
|
Alright, @martinsaposnic please ping me for review as soon as this is ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement changes introduced on lightningdevkit/rust-lightning#3838 for rust-lightning.
as discussed, client_trusts_lsp is a flag set at startup.
a new function receive_via_jit_channel_manual_claim is introduced to bolt11 so we allow the client to
manually claim a payment (used on tests).