Add simple workflow to generate Swift bindings in CI #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @jkczyz as a reviewer! |
tnull
force-pushed
the
2025-10-add-swift-CI
branch
from
e3b06ed to
cadd920
Compare
We add a simple workflows to generate the Swift bindings in CI, ensuring the build is succeeding.
.. no need to keep jobs running if we pushed once more.
tnull
force-pushed
the
2025-10-add-swift-CI
branch
from
cadd920 to
15a1b90
Compare
jkczyz
reviewed
Oct 30, 2025
| OfferId id(); | ||
| boolean is_expired(); | ||
| string? description(); | ||
| string? offer_description(); |
There was a problem hiding this comment.
CI is failing. Looks like some tests need to be updated, e.g.
Line 1364 in 134b2f7
Same for the other structs.
There was a problem hiding this comment.
Ah, right. Force-pushed fixes.
Swift will auto-generate a `description` accessor. We here avoid any conflicting methods in our API.
tnull
force-pushed
the
2025-10-add-swift-CI
branch
from
134b2f7 to
c554a24
Compare
|
CI failure should be fixed by #689. |
jkczyz
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a simple workflows to generate the Swift bindings in CI, ensuring the build is succeeding.