Skip to content

fix: update skills for upstream crate relocation and e2e simplification#13

Merged
slin1237 merged 1 commit intomainfrom
fix/update-skills-for-crate-move-and-e2e-simplification
Mar 9, 2026
Merged

fix: update skills for upstream crate relocation and e2e simplification#13
slin1237 merged 1 commit intomainfrom
fix/update-skills-for-crate-move-and-e2e-simplification

Conversation

@slin1237
Copy link
Copy Markdown
Member

@slin1237 slin1237 commented Mar 9, 2026

Summary

Update all dev guide skills to reflect upstream SMG repository changes since March 3:

  • Library crates moved from repo root to crates/ directory (smg#676)
  • E2E parallel testing infrastructure removed, replaced with sequential execution (smg#643, smg#587)
  • Multimodal crate types refactored (smg#590, smg#593)
  • New subsystems added (grpc_servicer, realtime API)

Refs: smg#676, smg#643, smg#587

What changed

Crate path migration (12 recipe files):

  • All library crate paths prefixed with crates/ to match new directory structure
  • Affected crates: auth, data_connector, grpc_client, kv_index, mcp, mesh, multimodal, protocols, reasoning_parser, tool_parser, wasm

Cargo package name fixes (3 files):

  • cargo check -p reasoning_parsercargo check -p reasoning-parser
  • cargo check -p tool_parsercargo check -p tool-parser
  • cargo test -p mcpcargo test -p smg-mcp

Codebase map updates (skills/map/SKILL.md):

  • Removed deleted MultiModalInputs type, added MediaConnector and per-model vision specs
  • Added grpc_servicer package to crate table
  • Added directory layout note explaining crates/ structure
  • Added realtime WebSocket request flow

E2E test reference updates (skills/review-pr/SKILL.md):

  • Removed @pytest.mark.thread_unsafe (parallel testing removed upstream)
  • Added current markers: @pytest.mark.engine(...), @pytest.mark.gpu(count), @pytest.mark.model(...)
  • Added note about sequential execution with class-scoped backends

Multimodal recipe update (skills/implement/multimodal-feature.md):

  • Updated vision processor steps for per-model spec registry modules (crates/multimodal/src/registry/)

Why

The upstream SMG repository restructured all library crates into a crates/ directory and simplified the E2E test infrastructure, making the dev guide skills out of date with incorrect filesystem paths, wrong cargo package names, deleted types, and removed test markers.

How verified

  • Grepped all skill files for old-style paths — zero remaining
  • Cross-referenced all crates/ paths against actual upstream repo structure
  • Verified cargo package names against each crate's Cargo.toml
  • Confirmed thread_unsafe marker no longer exists in upstream e2e_test/

Test plan

  • Verify smg:map skill shows correct crate locations
  • Verify smg:implement recipes reference correct file paths
  • Verify smg:review-pr file-to-section mapping matches upstream paths
  • Verify smg:contribute "Where Things Live" table is accurate

All library crates moved from repo root to crates/ directory (smg#676).
E2E parallel testing infrastructure removed in favor of sequential
execution with class-scoped backends (smg#643, smg#587).

What changed:
- skills/implement/*.md: prefix all library crate paths with crates/
  (auth, data_connector, grpc_client, kv_index, mcp, mesh, multimodal,
  protocols, reasoning_parser, tool_parser, wasm)
- skills/implement/reasoning-parser.md, tool-parser.md, mcp-feature.md:
  fix cargo -p package names (reasoning-parser, tool-parser, smg-mcp)
- skills/map/SKILL.md: update multimodal key types (remove deleted
  MultiModalInputs, add MediaConnector, per-model vision specs), add
  grpc_servicer to crate table, add directory layout note, add realtime
  WebSocket request flow
- skills/contribute/SKILL.md: update "Where Things Live" table paths
- skills/review-pr/SKILL.md: update file-to-section mapping paths,
  replace removed thread_unsafe marker with current e2e markers
  (engine, gpu, model), note sequential test execution
- skills/review-pr/anti-patterns.md: update protocols path references
- skills/implement/multimodal-feature.md: update vision processor steps
  for per-model spec registry modules

Why: upstream smg repository restructured crates into crates/ directory
and simplified e2e test infrastructure, making the dev guide skills
out of date with incorrect paths and removed test markers.

Refs: smg#676, smg#643, smg#587
Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
@slin1237 slin1237 merged commit d34083a into main Mar 9, 2026
2 checks passed
@slin1237 slin1237 deleted the fix/update-skills-for-crate-move-and-e2e-simplification branch March 9, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant