Conversation
All library crates moved from repo root to crates/ directory (smg#676). E2E parallel testing infrastructure removed in favor of sequential execution with class-scoped backends (smg#643, smg#587). What changed: - skills/implement/*.md: prefix all library crate paths with crates/ (auth, data_connector, grpc_client, kv_index, mcp, mesh, multimodal, protocols, reasoning_parser, tool_parser, wasm) - skills/implement/reasoning-parser.md, tool-parser.md, mcp-feature.md: fix cargo -p package names (reasoning-parser, tool-parser, smg-mcp) - skills/map/SKILL.md: update multimodal key types (remove deleted MultiModalInputs, add MediaConnector, per-model vision specs), add grpc_servicer to crate table, add directory layout note, add realtime WebSocket request flow - skills/contribute/SKILL.md: update "Where Things Live" table paths - skills/review-pr/SKILL.md: update file-to-section mapping paths, replace removed thread_unsafe marker with current e2e markers (engine, gpu, model), note sequential test execution - skills/review-pr/anti-patterns.md: update protocols path references - skills/implement/multimodal-feature.md: update vision processor steps for per-model spec registry modules Why: upstream smg repository restructured crates into crates/ directory and simplified e2e test infrastructure, making the dev guide skills out of date with incorrect paths and removed test markers. Refs: smg#676, smg#643, smg#587 Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update all dev guide skills to reflect upstream SMG repository changes since March 3:
crates/directory (smg#676)Refs: smg#676, smg#643, smg#587
What changed
Crate path migration (12 recipe files):
crates/to match new directory structureCargo package name fixes (3 files):
cargo check -p reasoning_parser→cargo check -p reasoning-parsercargo check -p tool_parser→cargo check -p tool-parsercargo test -p mcp→cargo test -p smg-mcpCodebase map updates (skills/map/SKILL.md):
MultiModalInputstype, addedMediaConnectorand per-model vision specsgrpc_servicerpackage to crate tablecrates/structureE2E test reference updates (skills/review-pr/SKILL.md):
@pytest.mark.thread_unsafe(parallel testing removed upstream)@pytest.mark.engine(...),@pytest.mark.gpu(count),@pytest.mark.model(...)Multimodal recipe update (skills/implement/multimodal-feature.md):
crates/multimodal/src/registry/)Why
The upstream SMG repository restructured all library crates into a
crates/directory and simplified the E2E test infrastructure, making the dev guide skills out of date with incorrect filesystem paths, wrong cargo package names, deleted types, and removed test markers.How verified
crates/paths against actual upstream repo structureCargo.tomlthread_unsafemarker no longer exists in upstreame2e_test/Test plan
smg:mapskill shows correct crate locationssmg:implementrecipes reference correct file pathssmg:review-prfile-to-section mapping matches upstream pathssmg:contribute"Where Things Live" table is accurate