Skip to content

Conversation

@github-actions
Copy link
Contributor

If this change should result in new package versions please add a changeset before merging. You can do so by clicking the link provided by changeset bot below.

- Remove `.mise.toml` from js/apps/private/ops, the root scripts will
  run ops as well.
- Renamed `start-<env>` to be `sparkcore-<env>` for consistency.
- Added `paycore-dev` to top level to join `paycore-local`.
- (Not mise) Fixed `start:minikube` being in the wrong `package.json`.

GitOrigin-RevId: 6a081d67c10ef5dded178906f03952a8b983ab1b
@github-actions github-actions bot requested a review from a team as a code owner October 28, 2025 18:01
@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 28, 2025

The following public packages have changed files:

Changed Current version
@lightsparkdev/ui 1.1.14

There are no existing changesets for this branch. If the changes in this PR should result in new published versions for the packages above please add a changeset. Any packages that depend on the planned releases will be updated and released automatically in a separate PR.

Each changeset corresponds to an update in the CHANGELOG for the packages listed in the changeset. Therefore, you should add a changeset for each noteable package change that this PR contains. For example, if a PR adds two features - one feature for packages A and B and one feature for package C - you should add two changesets. One changeset for packages A and B and one changeset for package C, with a description of each feature. The feature description will end up being the CHANGELOG entry for the packages in the changeset.

No releases planned.

Last updated by commit 066f1c3

lightspark-ci-js-sdk bot and others added 5 commits October 28, 2025 18:49
Update public `js` sources with the latest code from the [public
repository](https://github.com/lightsparkdev/js-sdk) main branch.

This typically happens when new versions of the SDK are released and
version updates need to be synced. The PR should be merged as soon as
possible to avoid updates to webdev overwriting the changes in the
js-sdk develop branch.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Lightspark Eng <engineering@lightspark.com>
Co-authored-by: Corey Martin <coreyn.martin@gmail.com>
GitOrigin-RevId: 8a60f32fae73cd0762928b7eedce2b9c3f87afb3
## Reason

We need to validate account numbers because tazapay will not throw if it's invalid.

## Overview

- adds frontend validation for account numbers
- this PR just adds it for singapore
- also updates the singapore bank mapping to its final state
- adds popular singapore banks

## Test Plan

![Screenshot 2025-10-28 at 4.25.09 PM.png](https://app.graphite.dev/user-attachments/assets/807e4e5d-401b-4577-b62f-a76b52ce3bb5.png)

![Screenshot 2025-10-28 at 4.12.27 PM.png](https://app.graphite.dev/user-attachments/assets/edc5b81d-3140-463d-8102-5d8547b387d4.png)

![Screenshot 2025-10-28 at 4.23.39 PM.png](https://app.graphite.dev/user-attachments/assets/aad40daa-66cc-46bf-8991-388db63605f5.png)

![Screenshot 2025-10-28 at 4.23.48 PM.png](https://app.graphite.dev/user-attachments/assets/5ea98130-ca96-4dd0-b49a-ab9e04251ec9.png)

![Screenshot 2025-10-28 at 4.23.56 PM.png](https://app.graphite.dev/user-attachments/assets/53c14cf7-2d97-4b06-9690-9bfb18f80aa9.png)

![Screenshot 2025-10-28 at 4.24.07 PM.png](https://app.graphite.dev/user-attachments/assets/ae5e3906-068e-4fad-943a-fefb21fa198b.png)

![Screenshot 2025-10-28 at 4.25.05 PM.png](https://app.graphite.dev/user-attachments/assets/f98f1ecc-eb71-4717-b575-0b980622c040.png)

GitOrigin-RevId: 9388ac8ad29df7af948bcc7515cf6d6d9af2a9d6
…557)

## Reason

Let's make the cookie consent modal a little more friendly looking.
Also, we only want to display it to users onboarding in EU, so we check their geoIP before displaying

![Screenshot 2025-10-30 at 3.26.25 PM.png](https://app.graphite.dev/user-attachments/assets/143a4ab7-a6d0-43ec-ba5a-e93b5eec88c7.png)

GitOrigin-RevId: 85d42e1ae623e0fc24ec244a7b386d56ec654fa8
## Reason

Explain *why* this change is being made.

## Overview

For large or complex changes, describe what is being changed.

## Test Plan

Explain how you tested the change.

GitOrigin-RevId: b144880a5e8f43cba3348a90ac81b4dacead491c
## Reason

Handles scenarios where we want to show sections

## Overview

- allows optionally passing either a list of options to SearchSelector or a list of account sections
- adds popular banks for philippines
- adds "based on your location" section to partner selector
- fixes bug where country wasn't being selected correctly because it was using the component prop for the selected region and thus wasn't updating until the parent rerendered
- simplifies "filterOptions" to "filterOption"

## Test Plan

![Screenshot 2025-10-31 at 4.24.26 PM.png](https://app.graphite.dev/user-attachments/assets/6254871e-7e8a-4c2e-bfe8-5f18a5b94ed2.png)

![Screenshot 2025-10-31 at 4.24.31 PM.png](https://app.graphite.dev/user-attachments/assets/7bda9757-fd11-4f81-9279-895e62874452.png)

![Screenshot 2025-10-31 at 4.56.26 PM.png](https://app.graphite.dev/user-attachments/assets/9849b8eb-a734-4ded-ba20-a8d8ce92e23d.png)

![Screenshot 2025-10-31 at 5.17.08 PM.png](https://app.graphite.dev/user-attachments/assets/038f7500-04ce-4775-bce9-a83b75a96dec.png)

- removes section labels if all results filtered out
![Screenshot 2025-10-31 at 5.18.21 PM.png](https://app.graphite.dev/user-attachments/assets/72e6d6c8-0b00-421e-8499-39c12f937216.png)

GitOrigin-RevId: 0e5d5ab6252d86e7df3a2d21bd69859985331d6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants