Skip to content

Conversation

@krtek4
Copy link
Contributor

@krtek4 krtek4 commented Nov 15, 2015

This should fix #77

What do you think @jeanmonod ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's the right place to put this mercurial specific code... At first I was more expecting a new method on the VCS interface. Something like supportTaggingWithInteger(). But then the error have to be raised after the config have been parsed, at the beginning of the releaseaction...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't really happy about this either.

Maybe a validateConfig on VcsInterface ?

@krtek4 krtek4 changed the title ensure that we don't use SimpleGenerator with Mercurial fix Mercurial tests and add tag validation Nov 17, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a validateContext() on the version-generator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, because the generator work is a bit different than the other actions and the persister and there's no need at the time.
Adding it once we need it won't be a big issue.

Can we merge ? please, pretty please, PLEASE ! PLEASE !

@jeanmonod
Copy link
Member

There is two last issues, my small comment about the prerequistes in the list and the compatibility to 5.3, (see the Travis builds). Except that, I guess we can merge! Thanks for your work

@sseidelmann
Copy link

@jeanmonod Whats with this PR? We should integrate the HG Tag check. All my HG tests are failing because of this.

@dbu
Copy link
Member

dbu commented Nov 22, 2017

doing a minimal fix of the tests without the full improvement and better error reporting in #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using RMT with Mercurial and Simple version generation is broken when Mercurial version > 3

5 participants