Skip to content

pkg/hostagent: Update all ssh execution to support SSH address other than "127.0.0.1" #4241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2025
Merged

pkg/hostagent: Update all ssh execution to support SSH address other than "127.0.0.1" #4241

merged 3 commits into from
Oct 23, 2025

Conversation

@norio-nomura
Copy link
Contributor

@norio-nomura norio-nomura commented Oct 22, 2025 •
edited
Loading

Split from #4175

affected functions:

  • Copy to host
  • Reverse SSHFS
  • SSH port forwarding
    pkg/hostagent: Add HostAgent.sshAddressPort()

Following commits are also needed additionally to fix #4240

  • pkg/hostagent: Fix setupMount() to avoid changing HostAgent.sshConfig
  • pkg/sshutil: Fix SSHOptsRemovingControlPath() to avoid changing the original opts

@norio-nomura
pkg/hostagent: Update all ssh execution to support SSH address othe…
44cc362 
…r than "127.0.0.1"

Split from lima-vm#4175
Fixes lima-vm#4240

affected functions:
- Copy to host
- Reverse SSHFS
- SSH port forwarding

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>

pkg/hostagent: Add `HostAgent.sshAddressPort()`

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
@norio-nomura norio-nomura mentioned this pull request Oct 22, 2025
Closed
@norio-nomura
Copy link
Contributor Author

temporary merged #4238 into this to checking CI.

@norio-nomura
pkg/hostagent: Fix setupMount() to avoid changing `HostAgent.sshCon…
2171b0a 
…fig`

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
@norio-nomura
pkg/sshutil: Fix SSHOptsRemovingControlPath() to avoid changing the…
e151940 
… original `opts`

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
AkihiroSuda
AkihiroSuda reviewed Oct 22, 2025
View reviewed changes
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Oct 22, 2025
@norio-nomura
Copy link
Contributor Author

Now port forwarding works on Windows with LIMA_SSH_PORT_FORWARDER = 'true'.
By the way, it seems that "127.0.0.1" is used in sshAddress, and it also seems to be working with it. I don't understand why instSSHAddress was required.

@norio-nomura
Copy link
Contributor Author

norio-nomura commented Oct 23, 2025 •
edited
Loading

temporary merged #4238 into this to checking CI.

Dropped the commit merging #4238.

@norio-nomura norio-nomura marked this pull request as ready for review October 23, 2025 03:12
AkihiroSuda
AkihiroSuda approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jandubois jandubois merged commit 638f426 into lima-vm:master Oct 23, 2025
63 of 64 checks passed
@norio-nomura norio-nomura deleted the fix-4240 branch October 24, 2025 03:52
@norio-nomura
Copy link
Contributor Author

Thanks! 🙏🏻

@afbjorklund
Copy link
Member

This looks similar to what we had for the "external" driver, but I guess I can rebase that instead.

8900ebf

@norio-nomura norio-nomura mentioned this pull request Oct 29, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

SSH port forwarder does not seem to work at all on Windows

4 participants

@norio-nomura @afbjorklund @AkihiroSuda @jandubois