[HOT-FIX] Duplicated email subject after enabling thread mode #4110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/4110. |
dab246
force-pushed
the
bugfix/thread-toggle-duplicate-subject-on-web
branch
from
6e3a9c1 to
2adc6a3
Compare
tddang-linagora
previously approved these changes
Oct 17, 2025
hoangdat
previously approved these changes
Nov 2, 2025
|
dab246
force-pushed
the
bugfix/thread-toggle-duplicate-subject-on-web
branch
from
2adc6a3 to
d903008
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Duplicated email subject after enabling thread mode
Reproduce
Steps to reproduce
reproduce.mov
Root cause
The issue occurs because the EmailView uses a GlobalKey, which prevents the widget from being disposed of when switching views. As a result, when the EmailView is rebuilt, it retains the previous object state within the class instead of creating a fresh instance, causing outdated or incorrect data (such as the old email subject) to be displayed.
Resolved
Screen.Recording.2025-10-17.at.12.48.09.PM.mov