-
Notifications
You must be signed in to change notification settings - Fork 82
update the action schemas #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
4geru
wants to merge
7
commits into
line:main
Choose a base branch
from
4geru:4geru/update-the-flex-message-schema
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eucyt Hello. Euchi-san. I created the PR. I'm going to review by my self. |
dff40b2 to
7a189bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.





Background
The existing Flex Message schema was broken when attempting to create complex flex messages.
The previous implementation used a simple passthrough validation approach that couldn't handle the intricate structure and validation requirements of LINE's Flex Message format.
This resulted in:
To address these issues, this PR implements a comprehensive schema based on the official LINE OpenAPI specification: https://github.com/line/line-openapi/blob/main/messaging-api.yml
Summary
This PR completely refactors the Flex Message schema to provide comprehensive validation that aligns with the official LINE Messaging API specification, fixing the broken complex flex message creation and ensuring type safety for all flex message components.
Changes
Schema Architecture Fixes
Component Support (Based on OpenAPI spec)
Validation Enhancements
mdfor sizes) matching LINE's specificationAction Types (Complete OpenAPI coverage)
Technical Improvements
References
Todo