Refactored to profiler service

composer.json

@@ -18,7 +18,7 @@
         }
     ],
     "require": {
-        "link0/profiler": "~1.0"
+        "link0/profiler": "^1.0.0"
     },
     "require-dev": {
         "symfony/framework-bundle": "~2",

src/Link0/ProfilerBundle/EventListener/ProfilingEventListener.php

@@ -8,88 +8,65 @@
 namespace Link0\ProfilerBundle\EventListener;
 
 use Link0\Profiler\PersistenceHandler;
-use Link0\Profiler\Profiler;
-use Symfony\Component\Console\Event\ConsoleTerminateEvent;
-use Symfony\Component\HttpKernel\Event\GetResponseEvent;
-use Symfony\Component\Console\Event\ConsoleCommandEvent;
-use Symfony\Component\HttpKernel\TerminableInterface;
+use Link0\ProfilerBundle\Service\ProfilingService;
 
 /**
  * Class ProfilingEventListener
  *
  * Hooks into the symfony event system, and starts and stops the profiler on certain events
  *
- * Start:
- *  - console.command
- *  - kernel.request
- * Stop:
- *  - console.terminate
- *  - kernel.terminate
+ * You can configure this event listener in your services.yml in the following format
+ *
+ * services:
+ *   kernel.listener.link0profilerlistener:
+ *     class: Link0\ProfilerBundle\EventListener\ProfilingEventListener
+ *     param: [@profiling_service]
+ *     tags:
+ *       - { name: kernel.event_listener, event: console.command,   method: start }
+ *       - { name: kernel.event_listener, event: kernel.request,    method: start }
+ *       - { name: kernel.event_listener, event: console.terminate, method: stop  }
+ *       - { name: kernel.event_listener, event: kernel.terminate,  method: stop  }
  *
  * @package Link0\ProfilerBundle\EventListener
  */
-class ProfilingEventListener
+final class ProfilingEventListener
 {
     /**
      * @var \Link0\Profiler\Profiler
      */
-    private $profiler;
-
-    /**
-     * A persistence handler should be fed, since null will disable persisting profiles
-     *
-     * @param PersistenceHandler $handler
-     */
-    public function __construct(PersistenceHandler $handler = null)
-    {
-        $this->profiler = new Profiler($handler);
-    }
-
-    /**
-     * @return Profiler
-     */
-    public function getProfiler()
-    {
-        return $this->profiler;
-    }
+    private $profilingService;
 
     /**
-     * @event console.command
-     * @param ConsoleCommandEvent $event
+     * @param ProfilingService $profilingService
      */
-    public function onConsoleCommand(ConsoleCommandEvent $event)
+    public function __construct(ProfilingService $profilingService)
     {
-        $this->getProfiler()->start();
+        $this->profilingService = $profilingService;
     }
 
     /**
-     * @event kernel.request
-     * @param GetResponseEvent $event
+     * @return ProfilingService
      */
-    public function onKernelRequest(GetResponseEvent $event)
+    public function getProfilingService()
     {
-        if (!$event->isMasterRequest()) {
-            return;
-        }
-
-        $this->getProfiler()->start();
+        return $this->profilingService;
     }
 
     /**
-     * @event console.terminate
-     * @param ConsoleTerminateEvent $event
+     * Starts the profiler
      */
-    public function onConsoleTerminate(ConsoleTerminateEvent $event)
+    public function start()
     {
-        $this->getProfiler()->stop();
+        $this->getProfilingService()->start();
     }
 
     /**
-     * @event kernel.terminate
-     * @param TerminableInterface $event
+     * Stops the profiler
+     *
+     * @return \Link0\Profiler\Profile
      */
-    public function onKernelTerminate(TerminableInterface $event)
+    public function stop()
     {
-        $this->getProfiler()->stop();
+        return $this->getProfilingService()->stop();
     }
 }

src/Link0/ProfilerBundle/Resources/config/services.yml

@@ -1,5 +1,11 @@
 services:
     kernel.listener.link0profilerlistener:
         class: Link0\ProfilerBundle\EventListener\ProfilingEventListener
+        param: [@profiling_service]
         tags:
-            - { name: kernel.event_listener, event: console.command, method: onConsoleCommand }
+            - { name: kernel.event_listener, event: console.command,   method: start }
+            - { name: kernel.event_listener, event: kernel.request,    method: start }
+            - { name: kernel.event_listener, event: console.terminate, method: stop  }
+            - { name: kernel.event_listener, event: kernel.terminate,  method: stop  }
+    profiling_service:
+        class: Link0\ProfilerBundle\Service\ProfilingService

src/Link0/ProfilerBundle/Service/ProfilingService.php

@@ -0,0 +1,52 @@
+<?php
+
+/**
+ * ProfilingEventListener.php
+ *
+ * @author Dennis de Greef <github@link0.net>
+ */
+namespace Link0\ProfilerBundle\Service;
+
+use Link0\Profiler\PersistenceService;
+
+/**
+ * Class ProfilingService
+ *
+ * @package Link0\ProfilerBundle\Service
+ */
+final class ProfilingService
+{
+    /**
+     * @var \Link0\Profiler\PersistenceService
+     */
+    private $persistenceService;
+
+    /**
+     * @var \Link0\Profiler\Profiler
+     */
+    private $profiler;
+
+    /**
+     * @param PersistenceService $persistenceService
+     */
+    public function __construct(PersistenceService $persistenceService = null)
+    {
+        $this->persistenceService = $persistenceService;
+    }
+
+    /**
+     * Starts the profiler
+     */
+    public function start()
+    {
+        $this->profiler->start();
+    }
+
+    /**
+     * @return \Link0\Profiler\Profile
+     */
+    public function stop()
+    {
+        return $this->profiler->stop();
+    }
+}