Revert support for long to int type demotion #595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert support for long to int type demotion
Summary
Revert support for long to int type demotion introduced in #590 , #591 and #593 .
All modified files were reverted except for following files:
helper/impls/helper-impl-19/src/main/java/com/linkedin/avroutil1/compatibility/avro19/codec/ResolvingDecoder.java
helper/impls/helper-impl-110/src/main/java/com/linkedin/avroutil1/compatibility/avro110/codec/ResolvingDecoder.java
helper/impls/helper-impl-111/src/main/java/com/linkedin/avroutil1/compatibility/avro111/codec/ResolvingDecoder.java
In those I reverted almost everything except for "implements CustomDecoder" in class definitions because it is referenced in SpecificDatumReaderExt classes.
Any new files that were introduced in those PRs were kept and newly introduced java classes were marked as deprecated.
Details
First two versions (Avro 1.4 and 1.5) I reverted manually, then used copilot to revert the remaining versions. Later I found that I missed some things in manual commits, I didn't realize avro 1.4 and 1.5 files were touched in the last two PRs as well. I used copilot to verify that everything was reverted. Here is the summary:
🔄 Reverted Files
All modified implementation files have been reverted to their pre-commit state:
Adapter Classes (Avro 1.4, 1.6-1.11)
Avro14Adapter.java,Avro16Adapter.java,Avro17Adapter.java,Avro18Adapter.java,Avro19Adapter.java,Avro110Adapter.java,Avro111Adapter.javaCodec/Parsing Classes (All versions)
AliasAwareSpecificDatumReader.javaResolvingGrammarGenerator.javaSymbol.javaTest Files (All versions)
AvroCompatibilityHelperAvro14Test.javaAvroCompatibilityHelperAvro15Test.javaAvroCompatibilityHelperAvro16Test.javaAvroCompatibilityHelperAvro17Test.javaAvroCompatibilityHelperAvro18Test.javaAvroCompatibilityHelperAvro19Test.javaAvroCompatibilityHelperAvro110Test.javaAvroCompatibilityHelperAvro111Test.javaAvroCompatibilityHelperAvro1110Test.javaCodegen Files
SpecificRecordClassGenerator.java- Removed numeric conversion constructorsSpecificRecordGeneratorUtil.javaSpecificRecordTest.javaThe following 19 newly added Java classes have been kept but marked with
@Deprecated:Common Classes
Avro 1.4
Avro 1.6
Avro 1.7
Avro 1.8
Avro 1.9
Avro 1.10
Avro 1.11
Testing Done
built avro-schemas with a snapshot of this repo
built a local mp with a snapshot of avro-schemas